Merge pull request #76 from prgrms-web-devcourse-final-project/QUZ-130-Test-Domain-Module

[QUZ-130][TEST] domain module test, redis refactor

Author: NaMinhyeok

game-service/game-domain/src/main/kotlin/com/grepp/quizy/game/domain/game/GameManager.kt

@@ -6,11 +6,9 @@ import org.springframework.stereotype.Component
 class GameManager(
     private val gameRepository: GameRepository
 ) {
-    fun destroy(game: Game) {
-        gameRepository.delete(game)
-    }
 
     fun destroy(gameId: Long) {
         gameRepository.deleteById(gameId)
     }
+
 }

game-service/game-domain/src/main/kotlin/com/grepp/quizy/game/domain/game/GameRepository.kt

@@ -8,8 +8,6 @@ interface GameRepository {
 
     fun findByInviteCode(code: String): Game?
 
-    fun delete(game: Game)
-
     fun deleteById(id: Long)
 
 }

game-service/game-domain/src/main/kotlin/com/grepp/quizy/game/domain/game/GameVO.kt

@@ -182,11 +182,6 @@ data class Players(
         return Players(players - player)
     }
 
-    fun findPlayer(user: User): Player {
-        return players.find { it.user == user }
-            ?: throw GameException.GameNotParticipatedException
-    }
-
     fun findPlayer(userId: Long): Player {
         return players.find { it.user.id == userId }
             ?: throw GameException.GameNotParticipatedException
@@ -203,6 +198,14 @@ data class Players(
             ?: throw GameException.GameAlreadyParticipatedException
 
 
+    fun isAllParticipated(): Boolean {
+        return players.none() { it.isWaiting() }
+    }
+
+    fun isEmpty(): Boolean {
+        return players.isEmpty()
+    }
+
     private fun updatePlayerStatus(player: Player): List<Player> =
         players.map { p ->
             when (p.user) {
@@ -211,12 +214,4 @@ data class Players(
             }
         }
 
-    fun isEmpty(): Boolean {
-        return players.isEmpty()
-    }
-
-    fun isAllParticipated(): Boolean {
-        return players.none() { it.isWaiting() }
-    }
-
 }

game-service/game-domain/src/main/kotlin/com/grepp/quizy/game/domain/user/UserUpdater.kt

@@ -14,11 +14,6 @@ class UserUpdater(
         return userRepository.save(oldUser)
     }
 
-    fun updateRating(user: User, rating: Int) {
-        user.updateRating(rating)
-        userRepository.save(user)
-    }
-
     fun updateRating(id: Long, rating: Int) {
         val user = userRepository.findById(id)
             ?: throw UserException.UserNotFoundException

game-service/game-domain/src/main/kotlin/com/grepp/quizy/game/domain/useranswer/UserAnswerAppender.kt

@@ -6,7 +6,9 @@ import org.springframework.stereotype.Component
 class UserAnswerAppender(
     private val userAnswerRepository: UserAnswerRepository
 ) {
-    fun append(userAnswer: UserAnswer) {
-        userAnswerRepository.save(userAnswer)
+
+    fun append(userAnswer: UserAnswer): UserAnswer {
+        return userAnswerRepository.save(userAnswer)
     }
+
 }

game-service/game-domain/src/main/kotlin/com/grepp/quizy/game/domain/useranswer/UserAnswerRepository.kt

@@ -2,7 +2,7 @@ package com.grepp.quizy.game.domain.useranswer
 
 interface UserAnswerRepository {
 
-    fun save(userAnswer: UserAnswer): Long?
+    fun save(userAnswer: UserAnswer): UserAnswer
 
     fun findAllByGameIdAndUserId(gameId: Long, userId: Long): List<UserAnswer>