hotfix : fix quiz selection ratio calculation

s0o0bn · s0o0bn · commit f73a49520ff4 · 2024-12-08T22:59:24.000+09:00
diff --git a/quiz-service/quiz-domain/src/main/kotlin/com/grepp/quizy/quiz/domain/quizread/UserSearchedQuiz.kt b/quiz-service/quiz-domain/src/main/kotlin/com/grepp/quizy/quiz/domain/quizread/UserSearchedQuiz.kt
@@ -215,15 +215,12 @@ data class QuizDetailOption(
                 QuizDetailOption(
                         option.optionNumber,
                         option.content,
-                        roundUp(
-                                option.selectionCount.toDouble() /
-                                        total.toDouble()
-                        ),
+                        calculateSelectionRatio(option.selectionCount.toDouble(), total.toDouble()),
                         imagePath = imagePath
                 )
 
-        private fun roundUp(value: Double) =
-                round(value * 100) / 100.0
+        private fun calculateSelectionRatio(value: Double, total: Double) =
+                if (total > 0.0) round(value / total * 100) / 100.0 else 0.0
     }
 }
 

Original file line number	Diff line number	Diff line change
`@@ -215,15 +215,12 @@ data class QuizDetailOption(`
`215`	`215`	`QuizDetailOption(`
`216`	`216`	`option.optionNumber,`
`217`	`217`	`option.content,`
`218`		`- roundUp(`
`219`		`- option.selectionCount.toDouble() /`
`220`		`- total.toDouble()`
`221`		`- ),`
	`218`	`+ calculateSelectionRatio(option.selectionCount.toDouble(), total.toDouble()),`
`222`	`219`	`imagePath = imagePath`
`223`	`220`	`)`
`224`	`221`
`225`		`- private fun roundUp(value: Double) =`
`226`		`- round(value * 100) / 100.0`
	`222`	`+ private fun calculateSelectionRatio(value: Double, total: Double) =`
	`223`	`+ if (total > 0.0) round(value / total * 100) / 100.0 else 0.0`
`227`	`224`	`}`
`228`	`225`	`}`
`229`	`226`