From da89a1cec69ccb1506d2218aecdb12a56018918b Mon Sep 17 00:00:00 2001 From: Josh Farrant Date: Fri, 3 Jan 2025 09:43:51 +0000 Subject: [PATCH 1/2] update VideoPlayer.Source examples in docs to use remote image --- apps/docs/content/components/VideoPlayer.mdx | 32 ++++++++++++++------ 1 file changed, 22 insertions(+), 10 deletions(-) diff --git a/apps/docs/content/components/VideoPlayer.mdx b/apps/docs/content/components/VideoPlayer.mdx index 0ad94dfbe..edc1ce224 100644 --- a/apps/docs/content/components/VideoPlayer.mdx +++ b/apps/docs/content/components/VideoPlayer.mdx @@ -17,7 +17,7 @@ import {VideoPlayer} from '@primer/react-brand' ```jsx live - + ``` @@ -29,7 +29,7 @@ import {VideoPlayer} from '@primer/react-brand' poster="/brand/assets/example-poster.png" title="GitHub media player" > - + ``` @@ -38,7 +38,7 @@ import {VideoPlayer} from '@primer/react-brand' ```jsx live - + ``` @@ -47,7 +47,7 @@ import {VideoPlayer} from '@primer/react-brand' ```jsx live - + ``` @@ -64,7 +64,10 @@ import {VideoPlayer} from '@primer/react-brand' showVolumeControl={false} showFullScreenButton={false} > - + ``` @@ -73,7 +76,10 @@ import {VideoPlayer} from '@primer/react-brand' ```jsx live - + ``` @@ -87,7 +93,10 @@ import {VideoPlayer} from '@primer/react-brand' showBranding={false} showControlsWhenPaused={false} > - + ``` @@ -99,7 +108,10 @@ import {VideoPlayer} from '@primer/react-brand' title="GitHub media player" playIcon={() => } > - + ``` @@ -111,7 +123,7 @@ The `VideoPlayer` component exposes a `useVideo` hook that can be used to contro Full documentation for the `useVideo` hook can be found [below](#usevideo-context). ```tsx live -() => { +;() => { const MyVideoPlayer = () => { const {isPlaying, togglePlaying, seek} = useVideo() @@ -127,7 +139,7 @@ Full documentation for the `useVideo` hook can be found [below](#usevideo-contex showFullScreenButton={false} > From 4432f8ecc5bf397f66b1531025ed6efc59074566 Mon Sep 17 00:00:00 2001 From: Josh Farrant Date: Wed, 8 Jan 2025 16:29:41 +0000 Subject: [PATCH 2/2] update example video url to be absolute instead of relative --- apps/docs/content/components/VideoPlayer.mdx | 18 +++++++++--------- 1 file changed, 9 insertions(+), 9 deletions(-) diff --git a/apps/docs/content/components/VideoPlayer.mdx b/apps/docs/content/components/VideoPlayer.mdx index edc1ce224..4cdc08ea8 100644 --- a/apps/docs/content/components/VideoPlayer.mdx +++ b/apps/docs/content/components/VideoPlayer.mdx @@ -17,7 +17,7 @@ import {VideoPlayer} from '@primer/react-brand' ```jsx live - + ``` @@ -29,7 +29,7 @@ import {VideoPlayer} from '@primer/react-brand' poster="/brand/assets/example-poster.png" title="GitHub media player" > - + ``` @@ -38,7 +38,7 @@ import {VideoPlayer} from '@primer/react-brand' ```jsx live - + ``` @@ -47,7 +47,7 @@ import {VideoPlayer} from '@primer/react-brand' ```jsx live - + ``` @@ -65,7 +65,7 @@ import {VideoPlayer} from '@primer/react-brand' showFullScreenButton={false} > @@ -77,7 +77,7 @@ import {VideoPlayer} from '@primer/react-brand' ```jsx live @@ -94,7 +94,7 @@ import {VideoPlayer} from '@primer/react-brand' showControlsWhenPaused={false} > @@ -109,7 +109,7 @@ import {VideoPlayer} from '@primer/react-brand' playIcon={() => } > @@ -139,7 +139,7 @@ Full documentation for the `useVideo` hook can be found [below](#usevideo-contex showFullScreenButton={false} >