diff --git a/.github/workflows/ci.yml b/.github/workflows/ci.yml index 71e1b4bed..a1af06bad 100644 --- a/.github/workflows/ci.yml +++ b/.github/workflows/ci.yml @@ -3,7 +3,7 @@ on: push: branches: - main - pull_request_target: + pull_request: jobs: build: diff --git a/CHANGELOG.md b/CHANGELOG.md index 3dc447efb..6fc40f9b3 100644 --- a/CHANGELOG.md +++ b/CHANGELOG.md @@ -1,5 +1,39 @@ # Changelog +## 14.1.0 + +### 🚀 New Features + +- `git-pull-request-draft` https://github.com/primer/octicons/pull/613 +- `git-pull-request-closed` https://github.com/primer/octicons/pull/613 + +## 14.0.0 + +### 💥 Breaking changes + +- Remove `octoface` https://github.com/primer/octicons/pull/611 +- Rename `git-fork-24` to `repo-forked-24` https://github.com/primer/octicons/pull/593 + +### 🚀 New Features + +- `number` https://github.com/primer/octicons/pull/592 +- `hash` (previously `number`) https://github.com/primer/octicons/pull/592 +- `diamond` https://github.com/primer/octicons/pull/616 +- `single-select` https://github.com/primer/octicons/pull/612 +- `rows` https://github.com/primer/octicons/pull/617 +- `columns` https://github.com/primer/octicons/pull/617 +- `issue-draft` https://github.com/primer/octicons/pull/614 + +### 💅 Enhancements + +- `issue-opened` https://github.com/primer/octicons/pull/614 +- `issue-closed` https://github.com/primer/octicons/pull/614 + +### 🐛 Fixes + +- Fix 24px `arrow-up` icon https://github.com/primer/octicons/pull/594 +- Prevent clipping using `overflow: visible` https://github.com/primer/octicons/pull/607 + ## 13.0.0 ### 🚀 New Features diff --git a/docs/content/guidelines/usage.mdx b/docs/content/guidelines/usage.mdx index 8535b6e61..d809c91f6 100644 --- a/docs/content/guidelines/usage.mdx +++ b/docs/content/guidelines/usage.mdx @@ -52,10 +52,11 @@ Certain octicons are intended for a specific use case. Refer to the table below ### GitHub brand specific -| Icon | Metaphor | Usage | -| :--: | :--: | :--: | -| | **Octoface** | Represents the user. Conveys connection between GitHub and the user. Similar to the [myOctocat generator](https://myoctocat.com/). -| | **GH mark** | Brand logo use only. Follow [GitHub's brand guidelines](https://brand.github.com/) when using this octicon. + + +**GitHub mark** + +Brand logo use only. Follow [GitHub's brand guidelines](https://brand.github.com/) when using this octicon. ## Icon styling @@ -109,7 +110,7 @@ Specific icons have a stateful pair using a slash to indicate the "off/empty" st | Metaphor | Icon pairing | | :--: | :--: | -| Subscrib/Unsubscribe | / | +| Subscribe/Unsubscribe | / | | Save/Unsave | / | | Watch/Unwatch | / | diff --git a/icons/arrow-up-24.svg b/icons/arrow-up-24.svg index 6d879acbc..61e17e892 100644 --- a/icons/arrow-up-24.svg +++ b/icons/arrow-up-24.svg @@ -1 +1 @@ - \ No newline at end of file + \ No newline at end of file diff --git a/icons/columns-16.svg b/icons/columns-16.svg new file mode 100644 index 000000000..e3eb3796e --- /dev/null +++ b/icons/columns-16.svg @@ -0,0 +1 @@ + \ No newline at end of file diff --git a/icons/columns-24.svg b/icons/columns-24.svg new file mode 100644 index 000000000..2391b23c6 --- /dev/null +++ b/icons/columns-24.svg @@ -0,0 +1 @@ + \ No newline at end of file diff --git a/icons/diamond-16.svg b/icons/diamond-16.svg new file mode 100644 index 000000000..419a8293b --- /dev/null +++ b/icons/diamond-16.svg @@ -0,0 +1 @@ + \ No newline at end of file diff --git a/icons/diamond-24.svg b/icons/diamond-24.svg new file mode 100644 index 000000000..f10023f40 --- /dev/null +++ b/icons/diamond-24.svg @@ -0,0 +1 @@ + \ No newline at end of file diff --git a/icons/git-pull-request-closed-16.svg b/icons/git-pull-request-closed-16.svg new file mode 100644 index 000000000..28074cd95 --- /dev/null +++ b/icons/git-pull-request-closed-16.svg @@ -0,0 +1 @@ + \ No newline at end of file diff --git a/icons/git-pull-request-closed-24.svg b/icons/git-pull-request-closed-24.svg new file mode 100644 index 000000000..5b08fdc6a --- /dev/null +++ b/icons/git-pull-request-closed-24.svg @@ -0,0 +1 @@ + \ No newline at end of file diff --git a/icons/git-pull-request-draft-16.svg b/icons/git-pull-request-draft-16.svg new file mode 100644 index 000000000..3cf6b06ef --- /dev/null +++ b/icons/git-pull-request-draft-16.svg @@ -0,0 +1 @@ + \ No newline at end of file diff --git a/icons/git-pull-request-draft-24.svg b/icons/git-pull-request-draft-24.svg new file mode 100644 index 000000000..c8d86e938 --- /dev/null +++ b/icons/git-pull-request-draft-24.svg @@ -0,0 +1 @@ + \ No newline at end of file diff --git a/icons/hash-16.svg b/icons/hash-16.svg new file mode 100644 index 000000000..91716fd6a --- /dev/null +++ b/icons/hash-16.svg @@ -0,0 +1 @@ + \ No newline at end of file diff --git a/icons/hash-24.svg b/icons/hash-24.svg new file mode 100644 index 000000000..40a825ea3 --- /dev/null +++ b/icons/hash-24.svg @@ -0,0 +1 @@ + \ No newline at end of file diff --git a/icons/issue-closed-16.svg b/icons/issue-closed-16.svg index e3b71dd91..b2eaab197 100644 --- a/icons/issue-closed-16.svg +++ b/icons/issue-closed-16.svg @@ -1 +1 @@ - \ No newline at end of file + \ No newline at end of file diff --git a/icons/issue-closed-24.svg b/icons/issue-closed-24.svg index f052753f6..de1d3c994 100644 --- a/icons/issue-closed-24.svg +++ b/icons/issue-closed-24.svg @@ -1 +1 @@ - \ No newline at end of file + \ No newline at end of file diff --git a/icons/issue-draft-16.svg b/icons/issue-draft-16.svg new file mode 100644 index 000000000..e1e654ad5 --- /dev/null +++ b/icons/issue-draft-16.svg @@ -0,0 +1 @@ + \ No newline at end of file diff --git a/icons/issue-draft-24.svg b/icons/issue-draft-24.svg new file mode 100644 index 000000000..1288698e0 --- /dev/null +++ b/icons/issue-draft-24.svg @@ -0,0 +1 @@ + \ No newline at end of file diff --git a/icons/issue-opened-16.svg b/icons/issue-opened-16.svg index 74f93fbed..17a338d3e 100644 --- a/icons/issue-opened-16.svg +++ b/icons/issue-opened-16.svg @@ -1 +1 @@ - \ No newline at end of file + \ No newline at end of file diff --git a/icons/issue-opened-24.svg b/icons/issue-opened-24.svg index 92f44b41e..e9986c54d 100644 --- a/icons/issue-opened-24.svg +++ b/icons/issue-opened-24.svg @@ -1 +1 @@ - \ No newline at end of file + \ No newline at end of file diff --git a/icons/number-16.svg b/icons/number-16.svg index d3db88a3f..27ec696ce 100644 --- a/icons/number-16.svg +++ b/icons/number-16.svg @@ -1 +1 @@ - \ No newline at end of file + \ No newline at end of file diff --git a/icons/number-24.svg b/icons/number-24.svg index 5c2834a45..97cbca6ba 100644 --- a/icons/number-24.svg +++ b/icons/number-24.svg @@ -1 +1 @@ - \ No newline at end of file + \ No newline at end of file diff --git a/icons/octoface-16.svg b/icons/octoface-16.svg deleted file mode 100644 index d3664f66d..000000000 --- a/icons/octoface-16.svg +++ /dev/null @@ -1 +0,0 @@ - \ No newline at end of file diff --git a/icons/octoface-24.svg b/icons/octoface-24.svg deleted file mode 100644 index f63a4ef22..000000000 --- a/icons/octoface-24.svg +++ /dev/null @@ -1 +0,0 @@ - \ No newline at end of file diff --git a/icons/git-fork-24.svg b/icons/repo-forked-24.svg similarity index 100% rename from icons/git-fork-24.svg rename to icons/repo-forked-24.svg diff --git a/icons/rows-16.svg b/icons/rows-16.svg new file mode 100644 index 000000000..a7c4dccd4 --- /dev/null +++ b/icons/rows-16.svg @@ -0,0 +1 @@ + \ No newline at end of file diff --git a/icons/rows-24.svg b/icons/rows-24.svg new file mode 100644 index 000000000..74fd9fb10 --- /dev/null +++ b/icons/rows-24.svg @@ -0,0 +1 @@ + \ No newline at end of file diff --git a/icons/select-single-16.svg b/icons/select-single-16.svg new file mode 100644 index 000000000..a3a757bec --- /dev/null +++ b/icons/select-single-16.svg @@ -0,0 +1 @@ + \ No newline at end of file diff --git a/icons/single-select-24.svg b/icons/single-select-24.svg new file mode 100644 index 000000000..5965bc4f5 --- /dev/null +++ b/icons/single-select-24.svg @@ -0,0 +1 @@ + \ No newline at end of file diff --git a/lib/octicons_gem/lib/octicons/version.rb b/lib/octicons_gem/lib/octicons/version.rb index baa5915df..47f9a4371 100644 --- a/lib/octicons_gem/lib/octicons/version.rb +++ b/lib/octicons_gem/lib/octicons/version.rb @@ -1,3 +1,3 @@ module Octicons - VERSION = "13.0.0".freeze + VERSION = "14.1.0".freeze end diff --git a/lib/octicons_helper/Gemfile b/lib/octicons_helper/Gemfile index 86fd04f83..468270657 100644 --- a/lib/octicons_helper/Gemfile +++ b/lib/octicons_helper/Gemfile @@ -2,7 +2,7 @@ source "https://rubygems.org" gemspec -gem "octicons", "13.0.0" +gem "octicons", "14.1.0" gem "rails" group :development, :test do diff --git a/lib/octicons_helper/lib/octicons_helper/version.rb b/lib/octicons_helper/lib/octicons_helper/version.rb index ce453eb1e..1658237e8 100644 --- a/lib/octicons_helper/lib/octicons_helper/version.rb +++ b/lib/octicons_helper/lib/octicons_helper/version.rb @@ -1,3 +1,3 @@ module OcticonsHelper - VERSION = "13.0.0".freeze + VERSION = "14.1.0".freeze end diff --git a/lib/octicons_helper/octicons_helper.gemspec b/lib/octicons_helper/octicons_helper.gemspec index bda2cc3fd..c28561301 100644 --- a/lib/octicons_helper/octicons_helper.gemspec +++ b/lib/octicons_helper/octicons_helper.gemspec @@ -13,7 +13,7 @@ Gem::Specification.new do |s| s.require_paths = ["lib"] - s.add_dependency "octicons", "13.0.0" + s.add_dependency "octicons", "14.1.0" s.add_dependency "railties" s.add_dependency "actionview" end diff --git a/lib/octicons_jekyll/Gemfile b/lib/octicons_jekyll/Gemfile index b278be174..a3b250022 100644 --- a/lib/octicons_jekyll/Gemfile +++ b/lib/octicons_jekyll/Gemfile @@ -2,7 +2,7 @@ source "https://rubygems.org" gemspec -gem "octicons", "13.0.0" +gem "octicons", "14.1.0" group :development, :test do gem "minitest" diff --git a/lib/octicons_jekyll/jekyll-octicons.gemspec b/lib/octicons_jekyll/jekyll-octicons.gemspec index 02c2abc0d..17f2f6282 100644 --- a/lib/octicons_jekyll/jekyll-octicons.gemspec +++ b/lib/octicons_jekyll/jekyll-octicons.gemspec @@ -14,5 +14,5 @@ Gem::Specification.new do |s| s.require_paths = ["lib"] s.add_dependency "jekyll", ">= 3.6", "< 5.0" - s.add_dependency "octicons", "13.0.0" + s.add_dependency "octicons", "14.1.0" end diff --git a/lib/octicons_jekyll/lib/jekyll-octicons/version.rb b/lib/octicons_jekyll/lib/jekyll-octicons/version.rb index cfac965a0..ad486ffd0 100644 --- a/lib/octicons_jekyll/lib/jekyll-octicons/version.rb +++ b/lib/octicons_jekyll/lib/jekyll-octicons/version.rb @@ -3,6 +3,6 @@ module Liquid; class Tag; end; end module Jekyll class Octicons < Liquid::Tag - VERSION = "13.0.0".freeze + VERSION = "14.1.0".freeze end end diff --git a/lib/octicons_node/index.scss b/lib/octicons_node/index.scss index 31d97867a..dcf5e7775 100644 --- a/lib/octicons_node/index.scss +++ b/lib/octicons_node/index.scss @@ -2,4 +2,5 @@ display: inline-block; vertical-align: text-top; fill: currentColor; + overflow: visible; } diff --git a/lib/octicons_node/package.json b/lib/octicons_node/package.json index 7b3e787d5..61350773a 100644 --- a/lib/octicons_node/package.json +++ b/lib/octicons_node/package.json @@ -1,6 +1,6 @@ { "name": "@primer/octicons", - "version": "13.0.0", + "version": "14.1.0", "description": "A scalable set of icons handcrafted with <3 by GitHub.", "homepage": "https://primer.style/octicons", "author": "GitHub Inc.", diff --git a/lib/octicons_react/package.json b/lib/octicons_react/package.json index ec0091782..a137c3da8 100644 --- a/lib/octicons_react/package.json +++ b/lib/octicons_react/package.json @@ -1,6 +1,6 @@ { "name": "@primer/octicons-react", - "version": "13.0.0", + "version": "14.1.0", "description": "A scalable set of icons handcrafted with <3 by GitHub.", "homepage": "https://primer.style/octicons", "author": "GitHub, Inc.", diff --git a/lib/octicons_react/src/__tests__/__snapshots__/octicon.js.snap b/lib/octicons_react/src/__tests__/__snapshots__/octicon.js.snap index 49834dc95..bf7fb20e3 100644 --- a/lib/octicons_react/src/__tests__/__snapshots__/octicon.js.snap +++ b/lib/octicons_react/src/__tests__/__snapshots__/octicon.js.snap @@ -7,7 +7,7 @@ exports[`An icon component matches snapshot 1`] = ` fill="currentColor" height="16" role="img" - style="display: inline-block; user-select: none; vertical-align: text-bottom;" + style="display: inline-block; user-select: none; vertical-align: text-bottom; overflow: visible;" viewBox="0 0 16 16" width="16" > diff --git a/lib/octicons_react/src/get-svg-props.js b/lib/octicons_react/src/get-svg-props.js index a49b19dd2..a105c9070 100644 --- a/lib/octicons_react/src/get-svg-props.js +++ b/lib/octicons_react/src/get-svg-props.js @@ -30,7 +30,8 @@ export default function getSvgProps({ style: { display: 'inline-block', userSelect: 'none', - verticalAlign + verticalAlign, + overflow: 'visible' }, dangerouslySetInnerHTML: {__html: path} } diff --git a/lib/octicons_styled/package.json b/lib/octicons_styled/package.json index f8477499b..14c518c73 100644 --- a/lib/octicons_styled/package.json +++ b/lib/octicons_styled/package.json @@ -1,6 +1,6 @@ { "name": "@primer/styled-octicons", - "version": "13.0.0", + "version": "14.1.0", "description": "A scalable set of icons handcrafted with <3 by GitHub.", "homepage": "https://primer.style/octicons", "author": "GitHub, Inc.", diff --git a/package.json b/package.json index bf36a2891..6ad30bc8e 100644 --- a/package.json +++ b/package.json @@ -1,6 +1,6 @@ { "private": true, - "version": "13.0.0", + "version": "14.1.0", "scripts": { "version": "script/version", "test": "ava -v tests/*.js",