revert: restore deploy preview behavior (#5536)

* Revert "Fix Prod Storybook deployment (#5535)"

This reverts commit 8b96591.

* Revert "fix: deploy_preview workflow (#5529)"

This reverts commit be42cc6.

* Revert "Fixing deploy_preview workflow (#5526)"

This reverts commit 62353f2.

* Revert "Remove branch from preview_deploy.yml (#5523)"

This reverts commit e2075bd.

* Revert "Add landing page and upload vrt/aat reports to GitHub Pages (#5499)"

This reverts commit 5a6d7bb.

Author: joshblack

.github/workflows/ci.yml

@@ -170,7 +170,6 @@ jobs:
           path: playwright-report
       - name: check vrt-runner job status
         if: ${{ needs.vrt-runner.result == 'failure' }}
-        continue-on-error: true
         run: exit 1
 
   vrt-runner-all-flags:
@@ -247,7 +246,6 @@ jobs:
           path: playwright-report
       - name: check vrt-runner-all-flags job status
         if: ${{ needs.vrt-runner-all-flags.result == 'failure' }}
-        continue-on-error: true
         run: exit 1
 
   aat-runner:
@@ -320,7 +318,6 @@ jobs:
           path: playwright-report
       - name: Check aat-runner job status
         if: ${{ needs.aat-runner.result == 'failure' }}
-        continue-on-error: true
         run: exit 1
 
   aat-runner-all-flags:
@@ -397,7 +394,6 @@ jobs:
           path: playwright-report
       - name: Check aat-runner-all-flags job status
         if: ${{ needs.aat-runner-all-flags.result == 'failure' }}
-        continue-on-error: true
         run: exit 1
 
   build-components-json:

.github/workflows/deploy_preview.yml

@@ -10,7 +10,6 @@ jobs:
   build:
     if: ${{ github.event.pull_request.head.repo.full_name == 'primer/react' }}
     runs-on: ubuntu-latest
-
     steps:
       - name: Checkout repository
         uses: actions/checkout@v4
@@ -46,3 +45,34 @@ jobs:
         uses: actions/deploy-pages@v4
         with:
           preview: true
+
+  deploy-storybook:
+    name: Preview Storybook
+    if: ${{ github.event.pull_request.head.repo.full_name == 'primer/react' }}
+    needs: deploy-preview
+    permissions:
+      deployments: write
+    runs-on: ubuntu-latest
+    steps:
+      - uses: chrnorm/[email protected]
+        name: Create GitHub deployment for storybook
+        id: storybook
+        with:
+          token: ${{ secrets.GITHUB_TOKEN }}
+          environment: storybook-preview-${{ github.event.number }}
+          environment_url: '${{ needs.deploy-preview.outputs.deployment_url }}/storybook'
+      - name: Update storybook deployment status (success)
+        if: success()
+        uses: chrnorm/[email protected]
+        with:
+          token: ${{ secrets.GITHUB_TOKEN }}
+          environment-url: '${{ needs.deploy-preview.outputs.deployment_url }}/storybook'
+          state: 'success'
+          deployment-id: ${{ steps.storybook.outputs.deployment_id }}
+      - name: Update storybook deployment status (failure)
+        if: failure()
+        uses: chrnorm/[email protected]
+        with:
+          token: ${{ secrets.GITHUB_TOKEN }}
+          state: 'failure'
+          deployment-id: ${{ steps.storybook.outputs.deployment_id }}

.github/workflows/deploy_preview_with_reports.yml

@@ -16,11 +16,8 @@
     "start": "concurrently npm:start:*",
     "start:storybook": "npm run start:storybook -w @primer/react",
     "build:storybook": "script/build-storybook",
-    "build:storybook:preview": "script/build-storybook preview",
-    "build:storybook:preview_with_reports": "script/build-storybook preview_with_reports",
     "build:docs": "NODE_OPTIONS=--openssl-legacy-provider script/build-docs",
     "build:docs:preview": "NODE_OPTIONS=--openssl-legacy-provider script/build-docs preview",
-    "build:docs:preview_with_reports": "NODE_OPTIONS=--openssl-legacy-provider script/build-docs preview_with_reports",
     "build:components.json": "npm run build:components.json -w @primer/react",
     "lint": "eslint '**/*.{js,ts,tsx,md,mdx}' --max-warnings=0",
     "lint:css": "stylelint --rd -q '**/*.css'",

package.json

@@ -1,12 +1,9 @@
 #!/bin/bash
 set -e
 
-if [ "$1" == "preview" ]; then
+if [ -n "$1" ]; then
   export DEPLOY_ENV="preview"
-  npm run build:storybook:preview
-elif [ "$1" == "preview_with_reports" ]; then
-  export DEPLOY_ENV="preview"
-  npm run build:storybook:preview_with_reports
+  npm run build:storybook preview
 else
   export DEPLOY_ENV="production"
   npm run build:storybook