Skip to content

Commit 90bbaaa

Browse files
committed
add tests
1 parent 55b1f38 commit 90bbaaa

File tree

3 files changed

+77
-1
lines changed

3 files changed

+77
-1
lines changed

e2e/components/Button.test.ts

+18
Original file line numberDiff line numberDiff line change
@@ -626,4 +626,22 @@ test.describe('Button', () => {
626626
})
627627
}
628628
})
629+
630+
test.describe('Dev: Disabled variants', () => {
631+
for (const theme of themes) {
632+
test.describe(theme, () => {
633+
test('default @vrt', async ({page}) => {
634+
await visit(page, {
635+
id: 'components-button-devonly--disabled-button-variants',
636+
globals: {
637+
colorScheme: theme,
638+
},
639+
})
640+
641+
// Default state
642+
expect(await page.screenshot()).toMatchSnapshot(`Button.Disabled variants.${theme}.png`)
643+
})
644+
})
645+
}
646+
})
629647
})

packages/react/.storybook/primitives-v8.css

+2
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,8 @@
11
/* size/typography */
2+
@import '@primer/primitives/dist/css/base/motion/motion.css';
23
@import '@primer/primitives/dist/css/base/size/size.css';
34
@import '@primer/primitives/dist/css/base/typography/typography.css';
5+
@import '@primer/primitives/dist/css/functional/motion/motion.css';
46
@import '@primer/primitives/dist/css/functional/size/border.css';
57
@import '@primer/primitives/dist/css/functional/size/breakpoints.css';
68
@import '@primer/primitives/dist/css/functional/size/size-coarse.css';

packages/react/src/Button/Button.dev.stories.tsx

+57-1
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,8 @@
1-
import {SearchIcon, TriangleDownIcon, EyeIcon, IssueClosedIcon} from '@primer/octicons-react'
1+
import {SearchIcon, TriangleDownIcon, EyeIcon, IssueClosedIcon, HeartFillIcon} from '@primer/octicons-react'
22
import React from 'react'
33
import {Button, IconButton} from '.'
44
import {default as Text} from '../Text'
5+
import {Stack} from '../Stack'
56

67
export default {
78
title: 'Components/Button/DevOnly',
@@ -94,3 +95,58 @@ export const TestSxProp = () => {
9495
</div>
9596
)
9697
}
98+
99+
export const DisabledButtonVariants = () => {
100+
return (
101+
<Stack direction="horizontal">
102+
<Stack align="start">
103+
<Button
104+
variant="invisible"
105+
leadingVisual={SearchIcon}
106+
trailingAction={TriangleDownIcon}
107+
trailingVisual={HeartFillIcon}
108+
count={4}
109+
disabled
110+
>
111+
Invisible
112+
</Button>
113+
<Button
114+
variant="default"
115+
leadingVisual={SearchIcon}
116+
trailingAction={TriangleDownIcon}
117+
trailingVisual={HeartFillIcon}
118+
count={4}
119+
disabled
120+
>
121+
Default
122+
</Button>
123+
<Button
124+
variant="primary"
125+
leadingVisual={SearchIcon}
126+
trailingAction={TriangleDownIcon}
127+
trailingVisual={HeartFillIcon}
128+
count={4}
129+
disabled
130+
>
131+
Primary
132+
</Button>
133+
<Button
134+
variant="danger"
135+
leadingVisual={SearchIcon}
136+
trailingAction={TriangleDownIcon}
137+
trailingVisual={HeartFillIcon}
138+
count={4}
139+
disabled
140+
>
141+
Danger
142+
</Button>
143+
</Stack>
144+
<Stack>
145+
<IconButton icon={HeartFillIcon} variant="invisible" aria-label="Invisible" disabled />
146+
<IconButton icon={HeartFillIcon} variant="default" aria-label="Default" disabled />
147+
<IconButton icon={HeartFillIcon} variant="primary" aria-label="Primary" disabled />
148+
<IconButton icon={HeartFillIcon} variant="danger" aria-label="Danger" disabled />
149+
</Stack>
150+
</Stack>
151+
)
152+
}

0 commit comments

Comments
 (0)