Skip to content

Commit e50b146

Browse files
committed
Revert "feat(ActionList sub components) Convert to CSS Modules (#5398)"
This reverts commit 215d8e6.
1 parent ee16256 commit e50b146

File tree

104 files changed

+1026
-2377
lines changed

Some content is hidden

Large Commits have some content hidden by default. Use the searchbox below for content that may be hidden.

104 files changed

+1026
-2377
lines changed

e2e/components/ActionList.test.ts

+27-88
Original file line numberDiff line numberDiff line change
@@ -313,38 +313,33 @@ test.describe('ActionList', () => {
313313
}
314314
})
315315

316-
// removing this temporarily as there is a slight diff betqeen default and enabled CSS feature flag that feels like a non-issue
317-
// eslint-disable-next-line jest/no-commented-out-tests
318-
// test.describe('Text Wrap And Truncation', () => {
319-
// for (const theme of themes) {
320-
// eslint-disable-next-line jest/no-commented-out-tests
321-
// test.describe(theme, () => {
322-
// eslint-disable-next-line jest/no-commented-out-tests
323-
// test('default @vrt', async ({page}) => {
324-
// await visit(page, {
325-
// id: 'components-actionlist-features--text-wrap-and-truncation',
326-
// globals: {
327-
// colorScheme: theme,
328-
// },
329-
// })
330-
331-
// // Default state
332-
// expect(await page.screenshot()).toMatchSnapshot(`ActionList.Text Wrap And Truncation.${theme}.png`)
333-
// })
334-
335-
// eslint-disable-next-line jest/no-commented-out-tests
336-
// test('axe @aat', async ({page}) => {
337-
// await visit(page, {
338-
// id: 'components-actionlist-features--text-wrap-and-truncation',
339-
// globals: {
340-
// colorScheme: theme,
341-
// },
342-
// })
343-
// await expect(page).toHaveNoViolations()
344-
// })
345-
// })
346-
// }
347-
// })
316+
test.describe('Text Wrap And Truncation', () => {
317+
for (const theme of themes) {
318+
test.describe(theme, () => {
319+
test('default @vrt', async ({page}) => {
320+
await visit(page, {
321+
id: 'components-actionlist-features--text-wrap-and-truncation',
322+
globals: {
323+
colorScheme: theme,
324+
},
325+
})
326+
327+
// Default state
328+
expect(await page.screenshot()).toMatchSnapshot(`ActionList.Text Wrap And Truncation.${theme}.png`)
329+
})
330+
331+
test('axe @aat', async ({page}) => {
332+
await visit(page, {
333+
id: 'components-actionlist-features--text-wrap-and-truncation',
334+
globals: {
335+
colorScheme: theme,
336+
},
337+
})
338+
await expect(page).toHaveNoViolations()
339+
})
340+
})
341+
}
342+
})
348343

349344
test.describe('With Avatars', () => {
350345
for (const theme of themes) {
@@ -745,60 +740,4 @@ test.describe('ActionList', () => {
745740
})
746741
}
747742
})
748-
749-
test.describe('Visuals with Classnames', () => {
750-
for (const theme of themes) {
751-
test.describe(theme, () => {
752-
test('default @vrt', async ({page}) => {
753-
await visit(page, {
754-
id: 'components-actionlist-dev--visual-custom-classname',
755-
globals: {
756-
colorScheme: theme,
757-
},
758-
})
759-
760-
// Default state
761-
expect(await page.screenshot()).toMatchSnapshot(`Visuals with Classnames.${theme}.png`)
762-
})
763-
764-
test('axe @aat', async ({page}) => {
765-
await visit(page, {
766-
id: 'components-actionlist-dev--visual-custom-classname',
767-
globals: {
768-
colorScheme: theme,
769-
},
770-
})
771-
await expect(page).toHaveNoViolations()
772-
})
773-
})
774-
}
775-
})
776-
777-
test.describe('Link Item Options', () => {
778-
for (const theme of themes) {
779-
test.describe(theme, () => {
780-
test('default @vrt', async ({page}) => {
781-
await visit(page, {
782-
id: 'components-actionlist-examples--list-link-item',
783-
globals: {
784-
colorScheme: theme,
785-
},
786-
})
787-
788-
// Default state
789-
expect(await page.screenshot()).toMatchSnapshot(`Link Item Options.${theme}.png`)
790-
})
791-
792-
test('axe @aat', async ({page}) => {
793-
await visit(page, {
794-
id: 'components-actionlist-examples--list-link-item',
795-
globals: {
796-
colorScheme: theme,
797-
},
798-
})
799-
await expect(page).toHaveNoViolations()
800-
})
801-
})
802-
}
803-
})
804743
})

packages/postcss-preset-primer/src/mixins/activeIndicatorLine.css

-11
This file was deleted.

packages/react/src/ActionList/ActionList.dev.stories.tsx

-24
Original file line numberDiff line numberDiff line change
@@ -7,7 +7,6 @@ import {Group} from './Group'
77
import {Divider} from './Divider'
88
import {Description} from './Description'
99
import Avatar from '../Avatar'
10-
import {FileDirectoryIcon, HeartFillIcon} from '@primer/octicons-react'
1110

1211
export default {
1312
title: 'Components/ActionList/Dev',
@@ -145,26 +144,3 @@ export const HeadingCustomClassname = () => (
145144
</ActionList.Group>
146145
</ActionList>
147146
)
148-
149-
export const DescriptionCustomClassname = () => (
150-
<ActionList>
151-
<ActionList.Item>
152-
Label
153-
<ActionList.Description className="testCustomClassnameColor">This is a description</ActionList.Description>
154-
</ActionList.Item>
155-
</ActionList>
156-
)
157-
158-
export const VisualCustomClassname = () => (
159-
<ActionList>
160-
<ActionList.Item>
161-
Label
162-
<ActionList.LeadingVisual className="testCustomClassnameColor">
163-
<FileDirectoryIcon />
164-
</ActionList.LeadingVisual>
165-
<ActionList.TrailingVisual className="testCustomClassnameColor">
166-
<HeartFillIcon />
167-
</ActionList.TrailingVisual>
168-
</ActionList.Item>
169-
</ActionList>
170-
)

packages/react/src/ActionList/ActionList.examples.stories.tsx

+1-13
Original file line numberDiff line numberDiff line change
@@ -94,21 +94,9 @@ export const ListLinkItem = () => (
9494
<ActionList.LeadingVisual>
9595
<LinkIcon />
9696
</ActionList.LeadingVisual>
97-
With inline description
97+
ActionList.LinkItem with everything
9898
<ActionList.Description variant="inline">inline description</ActionList.Description>
99-
</ActionList.LinkItem>
100-
<ActionList.LinkItem href="?path=/story/components-actionlist--default">
101-
<ActionList.LeadingVisual>
102-
<LinkIcon />
103-
</ActionList.LeadingVisual>
104-
With block description
10599
<ActionList.Description variant="block">Block description</ActionList.Description>
106-
</ActionList.LinkItem>
107-
<ActionList.LinkItem href="?path=/story/components-actionlist--default">
108-
<ActionList.LeadingVisual>
109-
<LinkIcon />
110-
</ActionList.LeadingVisual>
111-
Trailing visual
112100
<ActionList.TrailingVisual>⌘ + L</ActionList.TrailingVisual>
113101
</ActionList.LinkItem>
114102
</ActionList>

0 commit comments

Comments
 (0)