Spacing is off when using Banner with hideTitle, actions, and dismiss button

[dylanatsmith]

Description

In the similar With hidden title and actions example, the alignment is correct. Adding the dismiss button results in too much padding below the actions wrapper.

The margin should not be applied to dismissable banners when the title is hidden.

Steps to reproduce

Example code:

<Banner
  hideTitle
  description={<>Example description</>}
  primaryAction={<Banner.PrimaryAction>Button</Banner.PrimaryAction>}
  onDismiss={action('onDismiss')}
/>

Version

dotcom (37.0.0-rc.6)

Browser

No response

[github-actions]

Uh oh! @dylanatsmith, the image you shared is missing helpful alt text. Check your issue body.

Alt text is an invisible description that helps screen readers describe images to blind or low-vision users. If you are using markdown to display images, add your alt text inside the brackets of the markdown image.

Learn more about alt text at Basic writing and formatting syntax: images on GitHub Docs.

🤖 Beep boop! This comment was added automatically by github/accessibility-alt-text-bot.

[github-actions]

Uh oh! @dylanatsmith, the image you shared is missing helpful alt text. Check your issue body.

Alt text is an invisible description that helps screen readers describe images to blind or low-vision users. If you are using markdown to display images, add your alt text inside the brackets of the markdown image.

Learn more about alt text at Basic writing and formatting syntax: images on GitHub Docs.

🤖 Beep boop! This comment was added automatically by github/accessibility-alt-text-bot.

[siddharthkp]

• Maybe related: https://github.com/github/primer/issues/3720. Update: only a tiny overlap. Good to track these separately

[siddharthkp]

Thanks @dylanatsmith! Keep em coming!

• Fixed in Banner: Fix margin for inline actions #5053

[dylanatsmith]

Thanks for the quick fix @siddharthkp!