Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Return helpful response if any required header is missing #65

Open
gr2m opened this issue Feb 23, 2021 · 4 comments
Open

Return helpful response if any required header is missing #65

gr2m opened this issue Feb 23, 2021 · 4 comments

Comments

@gr2m
Copy link
Contributor

gr2m commented Feb 23, 2021

follow up to #63

/cc @axel3rd I think that would have saved you a lot of headache.

@axel3rd
Copy link
Contributor

axel3rd commented Feb 23, 2021

Yes 🤯 ^^, but could be part of #60

@gr2m
Copy link
Contributor Author

gr2m commented Feb 23, 2021

yes I agree. I'm just not sure how pointing to https://docs.aws.amazon.com/lambda/latest/dg/monitoring-cloudwatchlogs.html would be helpful?

AWS Lambda automatically monitors Lambda functions on your behalf, reporting metrics through Amazon CloudWatch. To help you troubleshoot failures in a function, Lambda logs all requests handled by your function and also automatically stores logs generated by your code through Amazon CloudWatch Logs.

@axel3rd
Copy link
Contributor

axel3rd commented Feb 23, 2021

I'm just not sure how pointing to https://docs.aws.amazon.com/lambda/latest/dg/monitoring-cloudwatchlogs.html would be helpful?

IMO, the CloudWatch logs is easy to access from Monitoring Tab (and not sure than Lambda Insight can be relevant here).

Using Probot log can do the job (log.debug for input event, log.error in the error catch).
And the HTTP content can depend of API integration (for sample I have never viewed a ooops message).

AWS Lambda automatically monitors Lambda functions on your behalf, reporting metrics through Amazon CloudWatch. To help you troubleshoot failures in a function, Lambda logs all requests handled by your function and also automatically stores logs generated by your code through Amazon CloudWatch Logs.

@gr2m
Copy link
Contributor Author

gr2m commented Feb 23, 2021

so in case of an error response, shall we include a JSON key such as

{
  "error": "...",
  "documentation_url": "https://docs.aws.amazon.com/lambda/latest/dg/monitoring-cloudwatchlogs.html"
}

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants