fix Cannot create a SharedArrayBuffer problem#3285
Closed
Indhiraraj wants to merge 8 commits intoprocessing:developfrom
Closed
fix Cannot create a SharedArrayBuffer problem#3285Indhiraraj wants to merge 8 commits intoprocessing:developfrom
Indhiraraj wants to merge 8 commits intoprocessing:developfrom
Conversation
Author
|
Hi @raclim , |
raclim
added
Type:Task
Collaborator
|
Thanks so much for working on this issue! I'm really sorry for the delay in getting back to this and for letting this PR go stale. Since a bit of time has passed, we might not move forward with this PR, but am definitely open to resubmission if you're still interested in this issue! I'm so sorry again for the delay on this! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #2094
Changes:
Implemented 'Cross-Origin-Embedder-Policy': 'require-corp' and 'Cross-Origin-Opener-Policy': 'same-origin' in both server.js and previewServer.js to enhance cross-origin security and enable origin isolation.
Created a proxy middleware to handle requests to the preview server, enabling communication despite the strict cross-origin policies.
Introduced a new environment variable PREVIEW_SERVER_URL (e.g., localhost:8000/preview) that points to the proxy for preview server requests.
Replaced all references to PREVIEW_URL in the client code with the newly introduced PREVIEW_SERVER_URL, ensuring compatibility with the proxy setup.
Added the new PREVIEW_SERVER_URL variable to the .env.example file to maintain consistency and support for future setups.
I have verified that this pull request:
npm run lint)npm run test)developbranch.Fixes #123