-
-
Notifications
You must be signed in to change notification settings - Fork 481
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update Getting Started text editor recommendations #1493
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@joenash please make a couple of adjustments:
- Limit the list of editors to Visual Studio Code
- Revise the Sublime guide to use VS Code instead (including screenshot)
Hey @nickmcintyre, I've made those changes, I do have questions about the i18n handling though. I removed I guess given the upcoming docs revamp that having some redundant lines lurking in the |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think this is great @joenash!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Oops. @joenash upon further review, the translations don't read clearly at all with the environment
blocks removed.
How about we try restoring the environment
blocks and simply put blank strings in en.yml
?
Sorry for the delay @nickmcintyre, this should be done now! |
@joenash @nickmcintyre Is this ready for merge? |
@limzykenneth nope, translations are still broken (missing links in the middle of sentences). Restoring the other editors to @joenash I suggest we close this issue in keeping with #1452. I'm sorry this fix wasn't as straightforward as I thought. The new p5.js website will be launched in a couple of months and there will countless opportunities to contribute! |
Sounds good, thanks @nickmcintyre. No need to apologise, sorry for taking up your time with reviewing this, I wasn't very familiar with the translation system going in and I should have checked what was happening there before opening the PR. Looking forward to the new site! |
Fixes #1492
Changes:
Todo: