Skip to content

Commit a7944d2

Browse files
committed
Fix limit parameter when neither page or offset is specified
1 parent 3e3567a commit a7944d2

File tree

2 files changed

+5
-1
lines changed

2 files changed

+5
-1
lines changed

lib/swapi/pagination.ex

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -60,7 +60,7 @@ defmodule SWAPI.Pagination do
6060
end
6161
end
6262

63-
defp do_paginate(query, _), do: do_paginate(query, %{"page" => "1"})
63+
defp do_paginate(query, params), do: do_paginate(query, Map.put(params, "page", "1"))
6464

6565
defp parse_integer(value) do
6666
case Integer.parse(value) do

test/swapi/pagination_test.exs

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -39,6 +39,10 @@ defmodule SWAPI.PaginationTest do
3939
assert %{id: 2} = person
4040
end
4141

42+
test "returns the correct number of items when page size is specified but no page or offset" do
43+
assert {:ok, {[_], _}} = Pagination.paginate(Person, %{"limit" => "1"})
44+
end
45+
4246
test "works with offset parameter" do
4347
assert {:ok, {[person | _], _}} = Pagination.paginate(Person, %{"offset" => "1"})
4448
assert %{id: 2} = person

0 commit comments

Comments
 (0)