Finish up the container-based linting. (#17404)

- `make lint` now runs through the build tools container

- Clean up several scripts

- Add lint check to ensure all generated code is up to date.

- Make the generated pilot type file generated through the normal
go:generate model, and rename the output file to have .gen in the
name.

- Updated common files.

Author: geeknoid

Makefile.core.mk

@@ -368,19 +368,13 @@ $(foreach bin,$(BINARIES),$(ISTIO_OUT_LINUX)/$(shell basename $(bin))): build-li
 # As an optimization, these still build everything
 $(foreach bin,$(BINARIES),$(shell basename $(bin))): build
 
-# Existence of build cache .a files actually affects the results of
-# some linters; they need to exist.
-lint: buildcache
-	SKIP_INIT=1 bin/linters.sh
-
 MARKDOWN_LINT_WHITELIST=localhost:8080,storage.googleapis.com/istio-artifacts/pilot/,http://ratings.default.svc.cluster.local:9080/ratings
 
-lint_modern: lint-python lint-copyright-banner lint-scripts lint-dockerfiles lint-markdown lint-yaml
+lint: lint-python lint-copyright-banner lint-scripts lint-dockerfiles lint-markdown lint-yaml gen check-clean
 	@bin/check_helm.sh
 	@bin/check_samples.sh
 	@bin/check_dashboards.sh
 	@go run mixer/tools/adapterlinter/main.go ./mixer/adapter/...
-	@bin/check_pilot_codegen.sh
 	@golangci-lint run -c ./common/config/.golangci.yml ./galley/...
 	@golangci-lint run -c ./common/config/.golangci.yml ./istioctl/...
 	@golangci-lint run -c ./common/config/.golangci.yml ./mixer/...
@@ -399,6 +393,15 @@ gen:
 	@go build -o /tmp/bin/mixgen "${REPO_ROOT}/mixer/tools/mixgen/main.go"
 	@PATH=${PATH}:/tmp/bin go generate ./...
 
+CHANGES=$(shell git status --porcelain)
+
+check-clean:
+ifneq ($(CHANGES),)
+	@git diff
+	@echo "Please run 'make gen' and include any changed files in your PR"
+	@exit 1
+endif
+
 #-----------------------------------------------------------------------------
 # Target: go build
 #-----------------------------------------------------------------------------

bin/check_pilot_codegen.sh

@@ -12,6 +12,9 @@
 // See the License for the specific language governing permissions and
 // limitations under the License.
 
+// nolint: lll
+//go:generate go run $REPO_ROOT/pilot/tools/generate_config_crd_types.go --template $REPO_ROOT/pilot/tools/types.go.tmpl --output $REPO_ROOT/pilot/pkg/config/kube/crd/types.gen.go
+
 package crd
 
 import (

bin/linters.sh

@@ -14,7 +14,7 @@
 
 // Tool to generate pilot/pkg/config/kube/types.go
 // Example run command:
-// go run pilot/tools/generate_config_crd_types.go --template pilot/tools/types.go.tmpl --output pilot/pkg/config/kube/crd/types.go
+// go run pilot/tools/generate_config_crd_types.go --template pilot/tools/types.go.tmpl --output pilot/pkg/config/kube/crd/types.gen.go
 package main
 
 import (