feat: some TODO implementation

Author: programadorthi

call-logging/common/src/dev/programadorthi/routing/callloging/MDC.kt

@@ -1,6 +1,5 @@
 package dev.programadorthi.routing.callloging
 
-// TODO: Do I need MDC in a context like JS and others?
 public expect object MDC {
     public fun clear()
 

call-logging/js/src/dev/programadorthi/routing/callloging/MDC.kt

@@ -1,15 +1,14 @@
 package dev.programadorthi.routing.callloging
 
 public actual object MDC {
-    // TODO: Is javascript multi thread? I don't know
     private val current = mutableMapOf<String, String>()
 
     public actual fun clear() {
         current.clear()
     }
 
     public actual fun getCopyOfContextMap(): Map<String, String>? {
-        return current
+        return current.toMap()
     }
 
     public actual fun remove(key: String) {

events-resources/common/test/dev/programadorthi/routing/events/EventResourcesRoutingTest.kt

@@ -279,7 +279,6 @@ class EventResourcesRoutingTest {
             }
 
             // WHEN
-            // TODO: For now, typed event is not supported by parent looking for child. We need to use path based
             parent.emitEvent(name = "/child/event_child")
             advanceTimeBy(99)
 

integration/compose-animation/build.gradle.kts

@@ -11,7 +11,6 @@ configureCommon()
 configureJvm()
 setupJvmToolchain()
 
-// TODO: org.jetbrains.compose.animation has targets limitation. That is the reason to duplicate configs below
 kotlin {
     explicitApi()
 

integration/javascript/js/src/dev/programadorthi/routing/javascript/JavascriptRouting.kt

@@ -1,11 +1,7 @@
 package dev.programadorthi.routing.javascript
 
-import dev.programadorthi.routing.core.RouteMethod
 import dev.programadorthi.routing.core.Routing
 import dev.programadorthi.routing.core.application
-import dev.programadorthi.routing.core.application.ApplicationCall
-import io.ktor.http.parametersOf
-import kotlinx.browser.window
 import kotlinx.coroutines.flow.MutableStateFlow
 import kotlinx.coroutines.launch
 import kotlinx.dom.clear
@@ -27,24 +23,5 @@ public fun render(
         }
     }
 
-    // First time or page refresh we try continue from last state
-    routing.tryNotifyTheRoute(state = window.history.state)
-
-    window.onpopstate = { event ->
-        routing.tryNotifyTheRoute(state = event.state)
-    }
-}
-
-private fun Routing.tryNotifyTheRoute(state: Any?) {
-    val javascriptState = state.deserialize() ?: return
-    val call =
-        ApplicationCall(
-            application = application,
-            name = javascriptState.name,
-            uri = javascriptState.uri,
-            routeMethod = RouteMethod.parse(javascriptState.routeMethod),
-            parameters = parametersOf(javascriptState.parameters),
-        )
-    call.neglect = true
-    execute(call)
+    JavascriptRoutingStateManager.init(routing)
 }

integration/javascript/js/src/dev/programadorthi/routing/javascript/JavascriptRoutingBuilder.kt

@@ -5,6 +5,7 @@ import dev.programadorthi.routing.core.RouteMethod
 import dev.programadorthi.routing.core.application.ApplicationCall
 import dev.programadorthi.routing.core.application.application
 import dev.programadorthi.routing.core.application.call
+import dev.programadorthi.routing.core.asRouting
 import dev.programadorthi.routing.core.route
 import io.ktor.util.pipeline.PipelineContext
 import io.ktor.utils.io.KtorDsl
@@ -28,6 +29,8 @@ public fun Route.jsRoute(
 
 @KtorDsl
 public fun Route.jsRoute(body: PipelineContext<Unit, ApplicationCall>.() -> Element) {
+    val routing = asRouting ?: error("A route must be a Routing child")
+
     handle {
         application.routingFlow.emit(body(this))
 
@@ -50,7 +53,7 @@ public fun Route.jsRoute(body: PipelineContext<Unit, ApplicationCall>.() -> Elem
                     data = call.serialize(),
                 )
 
-            // TODO: Add support to replace all route method
+            RouteMethod.ReplaceAll -> JavascriptRoutingStateManager.replaceAll(call, routing)
         }
     }
 }

integration/javascript/js/src/dev/programadorthi/routing/javascript/JavascriptRoutingState.kt

@@ -27,6 +27,11 @@ internal fun ApplicationCall.serialize(): String {
 
 internal fun Any?.deserialize(): JavascriptRoutingState? =
     when (this) {
-        is String -> Json.decodeFromString(this)
+        is String -> toState()
         else -> null
     }
+
+private fun String.toState(): JavascriptRoutingState? =
+    runCatching {
+        Json.decodeFromString<JavascriptRoutingState>(this)
+    }.getOrNull()

integration/javascript/js/src/dev/programadorthi/routing/javascript/JavascriptRoutingStateManager.kt

@@ -0,0 +1,76 @@
+package dev.programadorthi.routing.javascript
+
+import dev.programadorthi.routing.core.RouteMethod
+import dev.programadorthi.routing.core.Routing
+import dev.programadorthi.routing.core.application
+import dev.programadorthi.routing.core.application.ApplicationCall
+import io.ktor.http.parametersOf
+import kotlinx.browser.window
+import kotlinx.coroutines.withTimeout
+import kotlin.coroutines.resume
+import kotlin.coroutines.suspendCoroutine
+
+internal object JavascriptRoutingStateManager {
+    fun init(routing: Routing) {
+        // First time or page refresh we try continue from last state
+        routing.tryNotifyTheRoute(state = window.history.state)
+
+        resetOnPopStateEvent(routing)
+    }
+
+    suspend fun replaceAll(
+        call: ApplicationCall,
+        routing: Routing,
+    ) {
+        while (true) {
+            window.history.replaceState(
+                title = "",
+                url = null,
+                data = null,
+            )
+            window.history.go(-1)
+            val forceBreak =
+                runCatching {
+                    withTimeout(1_000) {
+                        suspendCoroutine { continuation ->
+                            window.onpopstate = { event ->
+                                val state = event.state.deserialize()
+                                continuation.resume(state == null)
+                            }
+                        }
+                    }
+                }.getOrDefault(true)
+            if (forceBreak) {
+                break
+            }
+        }
+
+        window.history.replaceState(
+            title = "routing",
+            url = call.uri,
+            data = call.serialize(),
+        )
+
+        resetOnPopStateEvent(routing)
+    }
+
+    private fun resetOnPopStateEvent(routing: Routing) {
+        window.onpopstate = { event ->
+            routing.tryNotifyTheRoute(state = event.state)
+        }
+    }
+
+    private fun Routing.tryNotifyTheRoute(state: Any?) {
+        val javascriptState = state.deserialize() ?: return
+        val call =
+            ApplicationCall(
+                application = application,
+                name = javascriptState.name,
+                uri = javascriptState.uri,
+                routeMethod = RouteMethod.parse(javascriptState.routeMethod),
+                parameters = parametersOf(javascriptState.parameters),
+            )
+        call.neglect = true
+        execute(call)
+    }
+}

integration/voyager/build.gradle.kts

@@ -11,7 +11,6 @@ configureCommon()
 configureJvm()
 setupJvmToolchain()
 
-// TODO: Voyager has targets limitation. That is the reason to duplicate configs below
 kotlin {
     explicitApi()