-
Notifications
You must be signed in to change notification settings - Fork 114
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Introduction to Encoding Texts in TEI (translation from spanish) #610
Comments
Hello @ashlynstewart404 and @semanticnoodles, You can find the key files here:
You can review a preview of the lesson here: I noticed a couple minor things when processing this submission, which I've listed below:
My colleague @anisa-hawes will invite you to join us here on GitHub as an Outside Collaborator. This will give you the Write access you'll need to edit your lesson directly. Thank you very much for your time and your work! ✨ |
Hi @charlottejmc and @anisa-hawes, I wanted to flag some issues with the rendering of the page, but I can see you started fixing the problem, thanks! |
Thank you, @charlottejmc! -- Hello Ashlyn @ashlynstewart404, I've sent you the invitation to join as an Outside Collaborator so you will be able to edit the What's happening now?Your lesson has been moved to the next phase of our workflow which is Phase 2: Initial Edit. In this Phase, your editor Giulia @semanticnoodles will read your lesson, and provide some initial feedback. Giulia will post feedback and suggestions as a comment in this Issue, so that you can revise your draft in the following Phase 3: Revision 1. At the moment, you'll notice that the Preview doesn't render images – we are waiting until we receive the revised files before uploading these. We'll send you a note to confirm when the preview is complete and ready to review. %%{init: { 'logLevel': 'debug', 'theme': 'dark', 'themeVariables': {
'cScale0': '#444444', 'cScaleLabel0': '#ffffff',
'cScale1': '#882b4f', 'cScaleLabel1': '#ffffff',
'cScale2': '#444444', 'cScaleLabel2': '#ffffff'
} } }%%
timeline
Section Phase 1 <br> Submission
Who worked on this? : Publishing Assistant (@charlottejmc)
All Phase 1 tasks completed? : Awaiting revised images
Section Phase 2 <br> Initial Edit
Who's working on this? : Editor (@semanticnoodles)
Expected completion date? : June 3
Section Phase 3 <br> Revision 1
Who's responsible? : Author (@ashlynstewart404)
Expected timeframe? : ~30 days after feedback is received
|
here follows my initial review; I added the various points in the form of a checklist for your convenience, so it may facilitate you in keeping track of the changes. Overall, you did fantastic work by staying as close as possible to the original, and I appreciate that. Most of the flagged items in the list below are formatting inconsistencies/missing links. In a few limited cases, some expressions could be reviewed for improved clarity -- not sticking so close to the literal translation. You changed the examples to enhance understanding, and I believe you did a fantastic job, as they make more sense in English. Revisions list
Check the use of sentence case in the headings and please do not forget to implement the changes requested by @charlottejmc in the message quoted below. **Thank you very much for your excellent work!**🌟
|
Hello Ashlyn @ashlynstewart404, What's happening now?Your lesson has been moved to the next phase of our workflow which is Phase 3: Revision 1. This phase is an opportunity for you to revise your draft in response to @semanticnoodles's initial feedback. I've checked to ensure that you have the 'write access' you need to edit your draft directly. We ask authors to work on their own files with direct commits: we prefer you don't fork our repo, or use the Pull Request system to edit in ph-submissions. You can make direct commits to your file here: /en/drafts/translations/encoding-texts-tei-1.md. Remember that Charlotte and I are here to help if you encounter any practical problems! When you and Giulia are both happy with the revised draft, we will move forward to Phase 4: Open Peer Review. %%{init: { 'logLevel': 'debug', 'theme': 'dark', 'themeVariables': {
'cScale0': '#444444', 'cScaleLabel0': '#ffffff',
'cScale1': '#882b4f', 'cScaleLabel1': '#ffffff',
'cScale2': '#444444', 'cScaleLabel2': '#ffffff'
} } }%%
timeline
Section Phase 2 <br> Initial Edit
Who worked on this? : Editor (@semanticnoodles)
All Phase 2 tasks completed? : Yes
Section Phase 3 <br> Revision 1
Who's working on this? : Author (@ashlynstewart404)
Expected completion date? : June 29
Section Phase 4 <br> Open Peer Review
Who's responsible? : Reviewers (TBC)
Expected timeframe? : ~60 days after request is accepted
|
Hello @semanticnoodles and @ashlynstewart404, You'll see I've checked off a number of points from Giulia's helpful comment above. Please let me know if you need any more help with the outstanding points! |
Hello, @charlottejmc! I have cropped the images you requested and uploaded them here. If it's better for me to send them over email or upload them elsewhere, please let me know. Also, if you need to crop them more, feel free to shrink them to your liking if that is easier. |
And, @charlottejmc, here is a corrected first image (and again let me know if there's somewhere else I should send/upload): |
Sorry to keep spamming you, @charlottejmc, but I wanted to let you know that I added the alt text for the images into the file in ph-submissions/en/drafts/translations/encoding-texts-tei-1.md. I got a notification from GitHub that there was a build error, and I'll admit that I don't know what that means or how to fix it. 🙈 Hopefully I didn't break anything! |
Hello Ashlyn @ashlynstewart404, Don't worry! The build was breaking because you'd included (I've also gone through and added backticks `` around the tei tags so that they display as text: 1c3f06b) Thank you for sharing the images. It would be great if you could email these to Charlotte (programming.assistant[@]programminghistorian.org) in |
Hello @ashlynstewart404, I just wanted to check whether you've caught that we still need you to send the images to my email address? (EDIT: Actually, there is a mistake in the address you were given initially! Apologies if you had already sent the email – but could you please send it again to [email protected]? Thank you!) |
Hello all. Just noting here that I have edited @ashlynstewart404's comments above (here and here) to remove the embedded/linked images which can make Issue threads long and a little unwieldy. Thank you for sharing the image files with us directly via email. |
Hello @anisa-hawes and @charlottejmc! I have agreed to an extended deadline for @ashlynstewart404 to complete Phase 3 revisions. We are working towards the end of this week (August 2nd), after which I will review the revisions and confirm our next steps towards Phase 4 Open Peer Review. Thank you! |
Open Peer ReviewDuring Phases 2 and 3, I provided initial feedback on this lesson, then worked with Ashlyn @ashlynstewart404 to complete a first round of revisions, thanks to the support of Charlotte @charlottejmc and Anisa @anisa-hawes. In Phase 4 Open Peer Review, we invite feedback from others in our community. Welcome to Jennifer Isasi @jenniferisasi and Roman Bleier @bleierr! By participating in this peer review process, you are contributing to the creation of a useful and sustainable technical resource for the whole community. Thank you ✨ Please read the lesson, test the code, and post your review as a comment in this issue by October 21st. Reviewer Guidelines: A preview of the lesson: Notes:
Anti-Harassment PolicyThis is a statement of the Programming Historian's principles and sets expectations for the tone and style of all correspondence between reviewers, authors, editors, and contributors to our public forums. Programming Historian in English is dedicated to providing an open scholarly environment that offers community participants the freedom to thoroughly scrutinize ideas, to ask questions, make suggestions, or request clarification, but also provides a harassment-free space for all contributors to the project, regardless of gender, gender identity and expression, sexual orientation, disability, physical appearance, body size, race, age or religion, or technical experience. We do not tolerate harassment or ad hominem attacks of community participants in any form. Participants violating these rules may be expelled from the community at the discretion of the editorial board. If anyone witnesses or feels they have been the victim of the above described activity, please contact our ombudsperson Dr Ian Milligan. Thank you for helping us to create a safe space. |
Hello Ashlyn @ashlynstewart404, (I know that you and @charlottejmc are in touch by email to coordinate the replacement of Figure 8 - thank you What's happening now?Your lesson has been moved to the next phase of our workflow which is Phase 4: Open Peer Review. This phase is an opportunity for you to hear feedback from peers in the community. Giulia @semanticnoodles has invited two reviewers to read your lesson/translation, test your code, and provide constructive feedback. In the spirit of openness, reviews will be posted as comments in this issue (unless you specifically request a closed review). After both reviews, Giulia will summarise the suggestions to clarify your priorities in Phase 5: Revision 2. %%{init: { 'logLevel': 'debug', 'theme': 'dark', 'themeVariables': {
'cScale0': '#444444', 'cScaleLabel0': '#ffffff',
'cScale1': '#882b4f', 'cScaleLabel1': '#ffffff',
'cScale2': '#444444', 'cScaleLabel2': '#ffffff'
} } }%%
timeline
Section Phase 3 <br> Revision 1
Who worked on this? : Author (@name)
All Phase 3 tasks completed? : Yes
Section Phase 4 <br> Open Peer Review
Who's working on this? : Reviewers (@jenniferisasi + @bleierr)
Expected completion date? : October 21st
Section Phase 5 <br> Revision 2
Who's responsible? : Author (@ashlynstewart404)
Expected timeframe? : ~30 days after editor's summary
|
Dear all, Thanks @semanticnoodles for asking me to review this translation by @ashlynstewart404, who has done a wonderful job in not only translating but also localizing the lesson to the English-speaking audience by changing Quevedo's poem to Whitman's. I have read through it while also checking figures and I don't have but two comments that in no way prevent the reader from understanding the text:
Congrats and I look forward to seeing this lesson published soon to share it with students and colleagues! |
Programming Historian in English has received a proposal for a translation from Spanish, 'Introduction to Encoding Texts in TEI,' by @ashlynstewart404.
I have circulated this proposal for feedback within the English team. We have considered this proposal for:
We are pleased to have invited @ashlynstewart404 to develop this Proposal into a Submission to be developed under the guidance of @semanticnoodles as editor.
The Submission package should include:
We ask @ashlynstewart404 to share their Submission package with our Publishing team by email, copying in @semanticnoodles .
We've agreed a submission date of late April. We ask @ashlynstewart404 to contact us if they need to revise this deadline.
When the Submission package is received, our Publishing team will process the new lesson materials, and prepare a Preview of the initial draft. They will post a comment in this Issue to provide the locations of all key files, as well as a link to the Preview where contributors can read the lesson as the draft progresses.
If we have not received the Submission package by May, @semanticnoodles will attempt to contact @ashlynstewart404. If we do not receive any update, this Issue will be closed.
Our dedicated Ombudspersons are Ian Milligan (English), Silvia Gutiérrez De la Torre (español), Hélène Huet (français), and Luis Ferla (português) Please feel free to contact them at any time if you have concerns that you would like addressed by an impartial observer. Contacting the ombudspersons will have no impact on the outcome of any peer review.
The text was updated successfully, but these errors were encountered: