-
Notifications
You must be signed in to change notification settings - Fork 114
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Teaching History and Languages with a Strategy Computer Game: 0 A.D. in the Classroom #613
Comments
Hello @scottkleinman and @historical-theology, You can find the key files here:
You can review a preview of the lesson here: I noticed a couple things when setting this file up, which I've listed below:
|
Hello Corey @historical-theology, I've sent you an invitation to join us as Outside Collaborators here on GitHub. This will give you the Write access you'll need to edit your lesson directly. (There's no need to use the Git Pull Request system in our ph-submissions repository). What's happening now?Your lesson has been moved to the next phase of our workflow which is Phase 2: Initial Edit. In this Phase, your editor Scott @scottkleinman will read your lesson, and provide some initial feedback. Scott will post feedback and suggestions as a comment in this Issue, so that you can revise your draft in the following Phase 3: Revision 1. %%{init: { 'logLevel': 'debug', 'theme': 'dark', 'themeVariables': {
'cScale0': '#444444', 'cScaleLabel0': '#ffffff',
'cScale1': '#882b4f', 'cScaleLabel1': '#ffffff',
'cScale2': '#444444', 'cScaleLabel2': '#ffffff'
} } }%%
timeline
Section Phase 1 <br> Submission
Who worked on this? : Publishing Assistant (@charlottejmc)
All Phase 1 tasks completed? : Yes
Section Phase 2 <br> Initial Edit
Who's working on this? : Editor (@scottkleinman)
Expected completion date? : May 5
Section Phase 3 <br> Revision 1
Who's responsible? : Author (@historical-theology)
Expected timeframe? : ~30 days after feedback is received
|
Hello, Corey @historical-theology Here are some initial comments on your tutorial.
Could you please address these issues in a revision before I send the tutorial out to external reviewers? And, of course, let me know if you have any questions. |
What's happening now?Hello Corey @historical-theology. Your lesson has been moved to the next phase of our workflow which is Phase 3: Revision 1. This Phase is an opportunity for you to revise your draft in response to @scottkleinman's initial feedback. You can make direct commits to your file here: /en/drafts/originals/teach-history-and-languages-with-strategy-game.md. @charlottejmc or I can help if you encounter any practical problems! When you and Scott are both happy with the revised draft, we will move forward to Phase 4: Open Peer Review. %%{init: { 'logLevel': 'debug', 'theme': 'dark', 'themeVariables': {
'cScale0': '#444444', 'cScaleLabel0': '#ffffff',
'cScale1': '#882b4f', 'cScaleLabel1': '#ffffff',
'cScale2': '#444444', 'cScaleLabel2': '#ffffff'
} } }%%
timeline
Section Phase 2 <br> Initial Edit
Who worked on this? : Editor (@scottkleinman)
All Phase 1 tasks completed? : Yes
Section Phase 3 <br> Revision 1
Who's working on this? : Author (@historical-theology)
Expected completion date? : May 8
Section Phase 4 <br> Open Peer Review
Who's responsible? : Reviewers (TBC)
Expected timeframe? : ~60 days after request is accepted
|
Revision based on the feedback of @anisa-hawes and @scottkleinman in #613
@anisa-hawes , @charlottejmc , and @hawc2 , thank you for configuring all of this for us, and @scottkleinman , thank you for your thoughtful, extensive feedback. I have prepared a thorough revision (ec83e84) in which I have aimed to take seriously everything mentioned thus far in this issue thread. While preparing the revision, I also have made a number of smaller changes throughout the piece to improve its clarity.
The adjustments look satisfactory. I am concerned about legibility at the reduced resolutions, but I also think that readers following the body text will not struggle to know what is being depicted in the images.
I have expanded the alternative text for every image with greater specificity. Please let me know if the updated alternative texts suffice (and, if not, how they might be improved further). Also, feel free to make direct commits to improve their functional utility for potential readers who might be unable to view the images.
I have overhauled Tutorial Overview to include nearly all of these things. In the process, I have used your encouragement to write a "short narrative" as a way to create a kind of orienting hook or lead-in for the reader.
I have moved all of these things to the endnotes.
I have reworked this part of the Requirements section.
I have overhauled the section entitled "A Scholarship-aware Community Endeavor," partly by combining it with the previous "Team Building" section and condensing the result.
It is standard practice for what are often colloquially referred to as "computer players" or "bots" to be labeled formally as artificial intelligence (AI) units/players. Is there something specific that ought to be clarified within the tutorial about this? If not, and I have answered your question, I am comfortable leaving those references to AI as they are.
I have removed all instances in which GIMP is framed as a requirement, instead noting specifically that the reader may use the image editing software of his/her choice. At the same time, I have left in-place the detailed steps in GIMP for the benefit of persons without any background in digital image editing, since performing those digital image editing steps is necessary for successful topographic image importation in Atlas for 0 A.D.
The attention to detail that you have shown, @scottkleinman , is laudable, and I appreciate it. Thus far, I have appreciated how straightforward this GitHub-based approach is for the Programming Historian. While I hope that you will find this revision to be ready to be issued to external reviewers, I will be happy to fulfill any follow-up request(s) for revision that you might have. @historical-theology Corey Stephan, Ph.D. |
Thanks for getting back to me @historical-theology. I agree that we should leave the images as they are, to ensure legibility. Thank you very much for your work on the alt-text – I've made some minor edits, but overall it looks great! |
Thank you, Corey @historical-theology. We really appreciate your work on this first round of revisions. Scott @scottkleinman will aim to review your changes within the next fortnight by ~May 31st. After that, we'll confirm the next steps. |
@historical-theology, I am just emerging from the end-of-semester crush and finally able to have a look your revisions. They look good. One thing that has been lost, as far as I can tell, is a download link for GIMP, which still seems useful despite GIMP's not being a "requirement". So this is just a note to put that in before we publish. That said, I think we are ready to present the tutorial to peer reviewers. I'll start on this next week. |
Hello Corey @historical-theology, What's happening now?Your lesson has been moved to the next phase of our workflow which is Phase 4: Open Peer Review. This phase will be an opportunity for you to hear feedback from peers in the community. Caio @caiocmello has invited two reviewers to read your lesson, test your code, and provide constructive feedback. In the spirit of openness, reviews will be posted as comments in this issue (unless you specifically request a closed review). After both reviews, Caio will summarise the suggestions to clarify your priorities in Phase 5: Revision 2. %%{init: { 'logLevel': 'debug', 'theme': 'dark', 'themeVariables': {
'cScale0': '#444444', 'cScaleLabel0': '#ffffff',
'cScale1': '#882b4f', 'cScaleLabel1': '#ffffff',
'cScale2': '#444444', 'cScaleLabel2': '#ffffff'
} } }%%
timeline
Section Phase 3 <br> Revision 1
Who worked on this? : Author (@historical-theology)
All Phase 3 tasks completed? : Yes
Section Phase 4 <br> Open Peer Review
Who's working on this? : Reviewers (@adamlporter + @clauper-maker)
Expected completion date? : 22 Nov // 30 Nov
Section Phase 5 <br> Revision 2
Who's responsible? : Author (@historical-theology)
Expected timeframe? : ~30 days after editor's summary
|
Hello Corey @historical-theology, Caio Mello @caiocmello will now be taking on editorial responsibilities for this lesson. Caio's first step will be inviting two community peer reviewers to contribute their feedback. Caio will post an update here in the Issue when the reviewers' names are confirmed. I would like to take this opportunity to apologise for the extended delay, and thank you for your patience. Alex @hawc2 will be in touch with you by email in the coming days. With very best wishes, |
Dear @historical-theology, Sorry for the delay with your lesson. I've been actively looking for potential reviewers. I will do my best to speed up things from now on. Your lesson is very interesting and I'm happy to be able to help shape it for publication in the PH. During Phases 2 and 3, Scott Kleinman provided initial feedback on this lesson, then worked with Corey @historical-theology to complete a first round of revisions. I've now taken on editorial responsibilities for this lesson. In Phase 4 Open Peer Review, we invite feedback from others in our community. Welcome Adam Porter @adamlporter. By participating in this peer review process, you are contributing to the creation of a useful and sustainable technical resource for the whole community. Thank you. I am still awaiting confirmation of who will join us as a second peer reviewer. Please read the lesson, test the code, and post your review as a comment in this issue by November 22. Reviewer Guidelines: A preview of the lesson: --
|
Thank you for your attention to this submission, @caiocmello . I look forward to working with you as we move forward with this tutorial. While I await further progress in Phase 4, allow me to draw your attention to the minor problem that something is awry with the way that endnotes appear in the tutorial's preview. @anisa-hawes , might you be able to apply a fix and/or direct me to do so? My assumption is that I have committed a minor error in Markdown formatting. I have written the endnotes like this:
Yet, this is how they appear in the current preview: |
Hello @historical-theology, Thank you for flagging the problem with the endnotes. I've fixed the formatting for you now! It required indenting the bullet list by 4 spaces. |
Hello Corey @historical-theology, I've invited a second reviewer for your lesson. Welcome Ivan Siqueira @clauper-maker. By participating in this peer review process, you are contributing to the creation of a useful and sustainable technical resource for the whole community. Thank you! This lesson is now in Phase 4 Open Peer Review, when we invite feedback from others in our community. During Phases 2 and 3, Scott Kleinman provided initial feedback on this lesson, then worked with Corey @historical-theology to complete a first round of revisions. Now you can read the lesson, test the code, and post your review as a comment in this issue by December 30th. Please, let me know if you have any question regarding the reviewing process. Reviewer Guidelines: https://programminghistorian.org/en/reviewer-guidelines A preview of the lesson: --
|
I enjoyed reading this lesson and following along with it. One note: all the links should be checked. According to WildFire's website, in August they moved from Git to Gitea. So while the links to Git in the lesson work, they have a warning "This Trac instance is not used for development anymore!" and tell folks to go to Gitea instead. Updating these links to their Gitea locations would be helpful. I use a dual-boot machine and mostly stay in Linux (Ubuntu 24.04) but I was unable to get 0 AD to run. I spent time looking at different trouble shooting recommendations, etc., loading new libraries, etc., but could never get it to run. (My impression is that the decentralized Linux environment, a vast array of machines on which it runs, etc., means this happens some regularity; it is doubtless one reason for Linux's low usage rates. It's a great OS when you can get stuff to run on it, but it frequently frustrates even fairly sophisticated users.) When I turned to Windows, I was able to download and run the game. I loaded the Community Maps 2 module and found the provided directions very helpful. I played through the tutorial, so I had a feel for it. Then I returned to try to create my own map, following the lesson's directions. I wanted to create a scenario of the Roman seige of Yodfat, which Josephus describes. I was able to get the colored topo map from the recommended website and processed in GIMP.
The directions for this were clear and easy to follow. But when I tried to import it into the scenario editor, nothing displayed. Rather than showing me the image in the directions (a circular version of my map, with a birds-eye 45 degree view), I got a black screen. I was able to open my image in Paint and it is 320x320. So I know the image it there and available as a PNG. Thinking I screwed something up, I went through these steps again, making a greyscale image of Masada. That, too, displayed as a black screen. I'm not sure what I'm doing wrong, but I cannot follow along the instructions more at this point. This is unfortunate, because the terrain editor looks interesting. For example, there are major changes from the image at paragraph 74 to 75. The description says this was done using three tools for just a few minutes. This is amazing. Overall, I am impressed with the lesson. Beyond my observations about the not-very-important GIMP menu variations, I don't have recommendations. If I had been able to get my maps imported, so I follow the remainder of the steps, I might have made some additional comments. I'm sorry I can't offer more suggestions and feedback. |
@adamlporter , thank you for your thoughtful peer review. Here is a brief response, which I kindly request that @caiocmello , @anisa-hawes , and @charlottejmc also read. Please comment as you might deem to be helpful for the tutorial. I have enjoyed the collegiality with Programming Historian thus far.
This is an important -- potentially essential -- point to draw to our attention, since I submitted the first iteration in April and the major revision in May, both before the WildFire team announced that move (in August, as you noted). As part of future cleanup (after receiving the second report), I will be sure to change the relevant hyperlinks to direct the reader to the project's new, permanent home. The good news is that there are not many hyperlinks that have been affected by this change.
In an early (pre-submission) draft of this tutorial, I actually included a direct link to the GitHub repository in which a 0 A.D. coder maintains an up-to-date GNU/Linux AppImage. If you download the most recent AppImage Release, mark it as executable ( As a reminder, here is what the tutorial currently says for installation of 0 A.D.:
Might anyone here prefer this to be expanded or revised in any way? If so, please specify how. (@charlottejmc comes to mind here.)
I am pleased that all of this was straightforward for you.
Thanks. I will double-check that I have the wording copied exactly. At the same time, I will note that GIMP's user interface might vary subtly on different platforms, and it also might vary subtly from version to version. The fact that this part of the tutorial, which I prepared with the old version of GIMP in the Debian Stable repository, was easy for you to follow in a build for Windows (and presumably a more recent build at that) suggests that the current wording is easy to follow across different GIMP builds and that I only should adjust it if I did in fact misquote.
I am glad that this was straightforward for you, too.
I suspect that the problem might lie in something being broken in the build of Atlas (specifically Atlas -- not all of 0 A.D.) for Microsoft Windows that you were using (or even there being a Windows permission issue or something else simply not working properly with Atlas in Windows for you in your specific setup). If you happen to try to install 0 A.D. in Ubuntu again (perhaps by using the AppImage that I linked above), I would be curious if the topographic image file would load for you in that build of Atlas, thereby allowing you to complete this specific part of the tutorial.
Thank you again for your peer review report, @adamlporter . I am pleased that you have found the tutorial to be both clear and complete. @historical-theology Corey Stephan, Ph.D. |
Thank you for your thorough and thoughtful comments, Corey @historical-theology. Just a reminder that it is important to wait until both reviews are received before beginning to implement any changes. When both reviews are in, Caio @caiocmello will summarise them to clarify priorities for Phase 5 revisions. Thank you for your patience. |
Programming Historian in English has received a proposal for a lesson, 'Teaching History and Languages with a Strategy Computer Game: 0 A.D. in the Classroom' by @historical-theology.
I have circulated this proposal for feedback within the English team. We have considered this proposal for:
We are pleased to have invited @historical-theology to develop this Proposal into a Submission under the guidance of @scottkleinman as editor.
The Submission package should include:
@historical-theology has already shared their Submission package with our Publishing team by email, copying in @scottkleinman. Our Publishing team will now process the new lesson materials, and prepare a Preview of the initial draft. They will run any questions by the contributor and post a comment in this Issue to provide the locations of all key files, as well as a link to the Preview where contributors can read the lesson as the draft progresses.
Our dedicated Ombudspersons are Ian Milligan (English), Silvia Gutiérrez De la Torre (español), Hélène Huet (français), and Luis Ferla (português). Please feel free to contact them at any time if you have concerns that you would like addressed by an impartial observer. Contacting the ombudspersons will have no impact on the outcome of any peer review.
The text was updated successfully, but these errors were encountered: