Skip to content

Commit 18d04e8

Browse files
authored
Prevent 433 response for Nonutf8{User/Real}name (#244)
Sending `NICK foo` after connectClient() causes an ERR_NICKNAMEINUSE response instead of the expected RPL_WELCOME.
1 parent 6425e70 commit 18d04e8

File tree

1 file changed

+6
-6
lines changed

1 file changed

+6
-6
lines changed

irctest/server_tests/utf8.py

Lines changed: 6 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -54,15 +54,15 @@ def testNonutf8Realname(self):
5454
raise runner.IsupportTokenNotSupported("UTF8ONLY")
5555

5656
self.addClient()
57-
self.sendLine(2, "NICK foo")
57+
self.sendLine(2, "NICK bar")
5858
self.clients[2].conn.sendall(b"USER username * * :i\xe8rc\xe9\r\n")
5959

6060
d = self.clients[2].conn.recv(1024)
61-
if b" FAIL " in d or b" 468 " in d: # ERR_INVALIDUSERNAME
61+
if b"FAIL " in d or b"468 " in d: # ERR_INVALIDUSERNAME
6262
return # nothing more to test
63-
self.assertIn(b" 001 ", d)
63+
self.assertIn(b"001 ", d)
6464

65-
self.sendLine(2, "WHOIS foo")
65+
self.sendLine(2, "WHOIS bar")
6666
self.getMessages(2)
6767

6868
def testNonutf8Username(self):
@@ -71,7 +71,7 @@ def testNonutf8Username(self):
7171
raise runner.IsupportTokenNotSupported("UTF8ONLY")
7272

7373
self.addClient()
74-
self.sendLine(2, "NICK foo")
74+
self.sendLine(2, "NICK bar")
7575
self.sendLine(2, "USER 😊😊😊😊😊😊😊😊😊😊 * * :realname")
7676
m = self.getRegistrationMessage(2)
7777
if m.command in ("FAIL", "468"): # ERR_INVALIDUSERNAME
@@ -80,7 +80,7 @@ def testNonutf8Username(self):
8080
m,
8181
command="001",
8282
)
83-
self.sendLine(2, "WHOIS foo")
83+
self.sendLine(2, "WHOIS bar")
8484
self.getMessages(2)
8585

8686

0 commit comments

Comments
 (0)