Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

pullPolicy for brokerJob fetched from wrong section of values.yaml #713

Closed
melinda-mytra opened this issue Oct 31, 2024 · 1 comment · Fixed by #715
Closed

pullPolicy for brokerJob fetched from wrong section of values.yaml #713

melinda-mytra opened this issue Oct 31, 2024 · 1 comment · Fixed by #715
Labels
bug Something isn't working

Comments

@melinda-mytra
Copy link
Contributor

Describe the bug
In values.yaml, the image pullPolicy is listed under .Values.[type].configuration.brokerPod.image.pullPolicy.
However the pullPolicy actually used comes from a level up at .Values.udev.configuration.pullPolicy.

That means specifying the pullPolicy as documented in values.yaml has no effect.

Expected behavior
The pullPolicy documented in values.yaml is also the one used in the templates.

I'd imagine the templates should change, since the pullPolicy in the values is in the expected place, but either way around would work.

@melinda-mytra melinda-mytra added the bug Something isn't working label Oct 31, 2024
@github-project-automation github-project-automation bot moved this to Triage needed in Akri Roadmap Oct 31, 2024
@melinda-mytra melinda-mytra changed the title pullPolicy fetched from wrong section of values.yaml pullPolicy for brokerPod fetched from wrong section of values.yaml Oct 31, 2024
@melinda-mytra melinda-mytra changed the title pullPolicy for brokerPod fetched from wrong section of values.yaml pullPolicy for brokerJob fetched from wrong section of values.yaml Oct 31, 2024
@kate-goldenring
Copy link
Contributor

@melinda-mytra nice find. I agree that fixing this in the templates so jobs use the same pattern as pods is the right approach. Would you be willing to take this on?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
Status: Done
Development

Successfully merging a pull request may close this issue.

2 participants