Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Helm: Enable multiple separate udev configurations #714

Closed
melinda-mytra opened this issue Nov 4, 2024 · 3 comments
Closed

Helm: Enable multiple separate udev configurations #714

melinda-mytra opened this issue Nov 4, 2024 · 3 comments

Comments

@melinda-mytra
Copy link
Contributor

melinda-mytra commented Nov 4, 2024

Is your feature request related to a way you would like Akri extended? Please describe.
I want to apply different broker jobs to different USB device types. Currently I can only specify one udev configuration. If I've totally misunderstood this, please point me the right way.

Describe the solution you'd like
Make configurations under udev an iterable, so you can generate multiple seperate named udev configurations from values.yaml. E.g.

  udev:
    discovery:
      enabled: true
    configurations:
    -   name: akri-udev-stm
        capacity: 2
        enabled: true
        brokerJob:
          image:
             repository: "broker-x"
        discoveryDetails:
          udevRules:
            - 'SUBSYSTEM=="usb", ATTR{idVendor}=="xxx", ATTR{idProduct}=="xxx"'
    -   name: akri-udev-camera
        capacity: 4
        enabled: true
        brokerJob:
          image:
             repository: "broker-y"
        discoveryDetails:
          groupRecursive: true
          udevRules:
            - 'SUBSYSTEM=="usb", ATTR{idVendor}=="yyy", ATTR{idProduct}=="yyy"'

Describe alternatives you've considered

  • Using multiple udev rules: This doesn't enable running different brokers by device type
  • Creating my own templates for additional udev configurations and brokers: will try

Additional context
Add any other context or screenshots about the feature request here.

@kate-goldenring
Copy link
Contributor

@melinda-mytra rather than trying to do more with the Helm templates, i'd recommend using helm template to generate each udev configuration and then applying the Yaml files. Does this documentation help https://docs.akri.sh/user-guide/customizing-an-akri-installation#generating-modifying-and-applying-a-configuration?

@melinda-mytra
Copy link
Contributor Author

Thanks for the docs, that makes sense.
I do think it would be handy to have built in natively, although it's by no means a showstopper - a "nice to have". I haven't checked how complex it would be to do, so if the tradeoff isn't worth it happy to close this.

@kate-goldenring
Copy link
Contributor

I think i am always in favor of simplifying helm templates and charts and have found that in production, most people do not use charts to create custom resources, so I'll close this for now.

@github-project-automation github-project-automation bot moved this from Triage needed to Done in Akri Roadmap Nov 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done
Development

No branches or pull requests

2 participants