Incorrect min/max defaults for temperature

[hasty]

When only min or max is defined for an attribute, the generated value in GENERATED_MIN_MAX_DEFAULTS for the omitted limit does not seem to account for whether or not the underlying value is signed.

e.g.:

-    <attribute side="server" code="0x0011" name="OccupiedCoolingSetpoint" define="OCCUPIED_COOLING_SETPOINT" type="temperature" min="-27315" max="0x7FFF" writable="true" default="2600" optional="true">
+    <attribute side="server" code="0x0011" name="OccupiedCoolingSetpoint" define="OCCUPIED_COOLING_SETPOINT" type="temperature" min="-27315" writable="true" default="2600">

yields

-        { (uint16_t) 0xA28, (uint16_t) -0x6AB3, (uint16_t) 0x7FFF }, /* OccupiedCoolingSetpoint */                                 \
+        { (uint16_t) 0xA28, (uint16_t) -0x6AB3, (uint16_t) 0xFFFF }, /* OccupiedCoolingSetpoint */     

[bzbarsky-apple]

The XML relevant here is:

<type id="0xD8" description="Temperature"              name="temperature"       size="2"  analog="true"     signed="true" />

I think the issue is in endpoint_attribute_min_max_list which has this logic:

    let def = parseInt(mm.default)
    let min = parseInt(mm.min)
    let max = parseInt(mm.max)

    if (isNaN(def)) def = 0
    if (isNaN(min)) min = 0
    if (isNaN(max)) max = 0xffff

Compare determineAttributeDefaultValue which does isSignedInteger checks and acts accordingly (and ends up as the mm.default there). But for min/max we seem to be just grabbing the values from the XML directly without accounting for signedness anywhere.

I expect the min would be wrong too, if it were left out but max were provided, ending up as 0, not the min value for the type...