Skip to content

Convert openshift_oauth ingress to route #414

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
Bobbins228 opened this issue Nov 29, 2023 · 0 comments · Fixed by #437
Closed

Convert openshift_oauth ingress to route #414

Bobbins228 opened this issue Nov 29, 2023 · 0 comments · Fixed by #437
Assignees

Comments

@Bobbins228
Copy link
Contributor

Follow on from #407

WHY

As we move to create routes specifically for OpenShift users and ingresses for K8s users we should stick to using routes across the board for OpenShift clusters.

WHAT

What is being asked for?
Convert the ingress created when selecting openshift_oauth into a route.
Standardise the naming scheme of the routes to ray-dashboard-<cluster_name> and change route/ingress list requests to get requests using the standard naming scheme.

HOW

Convert the ingress object created here to a route object and replace necessary references from ingress to routes for openshift_oauth.

Update methods like _get_ingress_domain to instead use get_namespaced_custom_object and pass the new standard dashboard name to get the object.

DONE

Bullet point items for what should be completed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Development

Successfully merging a pull request may close this issue.

2 participants