Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for ResourceQuota #44

Open
atantawi opened this issue Nov 9, 2023 · 2 comments
Open

Add support for ResourceQuota #44

atantawi opened this issue Nov 9, 2023 · 2 comments

Comments

@atantawi
Copy link
Collaborator

atantawi commented Nov 9, 2023

ResourceQuota

In case a ResourceQuota object exists in the namespace of an AppWrapper, the dispatcher should check if the requests and limits of the AppWrapper are satisfied by the available quota in the ResourceQuota, before the AppWrapper is dispatched and the corresponding pods are created. This avoids some (or all) pods of the AppWrapper being rejected by the resource quota admission controller.

Handling of this issue may be done in phases:

  1. Basic handling of quota resources {cpu, memory, ...}, {requests.cpu, requests.memory, ...} and {limits.cpu, limits.memory, ...}, including extended resources.
  2. Consideration of object count quotas count/<resource>.<group> and count/<resource>.
  3. Cluster wide quotas: ClusterResourceQuota

Issues to worry about:

  • If a ResourceQuota object exists in the namespace of an AppWrapper, requests and limits need to be specified at the container and AppWrapper levels.
  • Accounting for used quota may get tricky! The reported Used quota in the ResourceQuota object reflects the pods that passed the quota admission controller AFTER the ResourceQuota object is created.
  • Updating the quota usage as AppWrapper are dispatched from the queue, and before their pods are actually created. Should this data be kept in the Cache, or recalculated when needed?
@atantawi
Copy link
Collaborator Author

Need to handle more than one ResourceQuota object per NameSpace.

@atantawi
Copy link
Collaborator Author

Need to handle scope of ResourceQuota objects.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant