Ignore finished workloads when scanning for abnormal conditions (#99)

project-codeflare · Nov 18, 2024 · 3fa9a98 · 3fa9a98
1 parent 27ee44c
commit 3fa9a98
Showing 1 changed file with 7 additions and 5 deletions.
diff --git a/tools/cluster-checker/checker.js b/tools/cluster-checker/checker.js
@@ -222,11 +222,13 @@ async function checkUserNamespace (client, namespace, queues) {
     for (const condition of workload.status?.conditions ?? []) {
       conditions[condition.type] = condition.status
     }
-    if (conditions.Admitted === 'True' && conditions.PodsReady === 'False') {
-      console.log(`WARNING: workload "${namespace.metadata.name}/${workload.metadata.name}" has conditions Admitted=True and PodsReady=False`)
-    }
-    if (conditions.Evicted === 'True') {
-      console.log(`WARNING: workload "${namespace.metadata.name}/${workload.metadata.name}" has condition Evicted=True`)
+    if (conditions.Finished !== 'True') {
+      if (conditions.Admitted === 'True' && conditions.PodsReady === 'False') {
+        console.log(`WARNING: workload "${namespace.metadata.name}/${workload.metadata.name}" has conditions Admitted=True and PodsReady=False`)
+      }
+      if (conditions.Evicted === 'True') {
+        console.log(`WARNING: workload "${namespace.metadata.name}/${workload.metadata.name}" has condition Evicted=True`)
+      }
     }
 
     // report misconfigured resource requests