Skip to content

Commit 085b5ce

Browse files
committed
Revert "Fix npm run dev failing because of missing log files when run for the first time"
This reverts commit 8d66cac.
1 parent 8d66cac commit 085b5ce

File tree

2 files changed

+6
-8
lines changed

2 files changed

+6
-8
lines changed

rust/plugin_runtime/src/deno.rs

Lines changed: 6 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -322,7 +322,9 @@ pub async fn start_js_runtime(
322322
let stdout = if let Some(stdout_file) = init.stdout_file {
323323
let stdout_file = PathBuf::from(stdout_file);
324324

325-
let out_log_file = File::open(stdout_file)?;
325+
std::fs::create_dir_all(stdout_file.parent().unwrap())?;
326+
327+
let out_log_file = File::create(stdout_file)?;
326328

327329
StdioPipe::file(out_log_file)
328330
} else {
@@ -332,7 +334,9 @@ pub async fn start_js_runtime(
332334
let stderr = if let Some(stderr_file) = init.stderr_file {
333335
let stderr_file = PathBuf::from(stderr_file);
334336

335-
let err_log_file = File::open(stderr_file)?;
337+
std::fs::create_dir_all(stderr_file.parent().unwrap())?;
338+
339+
let err_log_file = File::create(stderr_file)?;
336340

337341
StdioPipe::file(err_log_file)
338342
} else {

rust/server/src/plugins/js.rs

Lines changed: 0 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -154,17 +154,11 @@ pub async fn start_plugin_runtime(data: PluginRuntimeData, run_status_guard: Run
154154
let (stdout_file, stderr_file) = if dev_plugin {
155155
let (stdout_file, stderr_file) = data.dirs.plugin_log_files(&plugin_uuid);
156156

157-
std::fs::create_dir_all(stdout_file.parent().unwrap())?;
158-
File::create(&stdout_file)?;
159-
160157
let stdout_file = stdout_file
161158
.to_str()
162159
.context("non-uft8 paths are not supported")?
163160
.to_string();
164161

165-
std::fs::create_dir_all(stderr_file.parent().unwrap())?;
166-
File::create(&stderr_file)?;
167-
168162
let stderr_file = stderr_file.to_str()
169163
.context("non-uft8 paths are not supported")?
170164
.to_string();

0 commit comments

Comments
 (0)