Skip to content

Commit 1f113a8

Browse files
authored
Merge pull request #3762 from projectblacklight/revert_facet_search_builder
Revert "Extract FacetSearchBuilder"
2 parents a53947f + 0401368 commit 1f113a8

File tree

14 files changed

+379
-1268
lines changed

14 files changed

+379
-1268
lines changed

app/controllers/concerns/blacklight/catalog.rb

Lines changed: 3 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -9,7 +9,6 @@ module Blacklight::Catalog
99
include Blacklight::Configurable
1010
include Blacklight::SearchContext
1111
include Blacklight::Searchable
12-
include Blacklight::Facetable
1312

1413
# The following code is executed when someone includes blacklight::catalog in their
1514
# own controller.
@@ -82,11 +81,11 @@ def facet
8281
raise ActionController::RoutingError, 'Not Found' unless @facet
8382

8483
@response = if params[:query_fragment].present?
85-
facet_search_service.facet_suggest_response(@facet.key, params[:query_fragment])
84+
search_service.facet_suggest_response(@facet.key, params[:query_fragment])
8685
else
87-
facet_search_service.facet_field_response(@facet.key)
86+
search_service.facet_field_response(@facet.key)
8887
end
89-
88+
# @display_facet is a Blacklight::Solr::Response::Facets::FacetField
9089
@display_facet = @response.aggregations[@facet.field]
9190

9291
# @presenter is a Blacklight::FacetFieldPresenter

app/controllers/concerns/blacklight/facetable.rb

Lines changed: 0 additions & 34 deletions
This file was deleted.

app/models/facet_search_builder.rb

Lines changed: 0 additions & 5 deletions
This file was deleted.

app/services/blacklight/facet_search_service.rb

Lines changed: 0 additions & 44 deletions
This file was deleted.

lib/blacklight/abstract_search_builder.rb

Lines changed: 0 additions & 154 deletions
This file was deleted.

lib/blacklight/configuration.rb

Lines changed: 0 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -103,9 +103,6 @@ def initialized_default_configuration?
103103
# @!attribute search_builder_class
104104
# @return [Class] class for converting Blacklight parameters to request parameters for the repository_class
105105
property :search_builder_class, default: ::SearchBuilder
106-
# @!attribute search_builder_class
107-
# @return [Class] class for converting Blacklight parameters to request parameters for the repository_class
108-
property :facet_search_builder_class, default: ::FacetSearchBuilder
109106
# @!attribute response_model
110107
# model that maps index responses to the blacklight response model
111108
# @return [Class]

lib/blacklight/facet_search_builder.rb

Lines changed: 0 additions & 18 deletions
This file was deleted.

0 commit comments

Comments
 (0)