Skip to content

Commit 5403e33

Browse files
committed
Remove comments that imply Bootstrap 4 is still supported in BL9 (it is not).
- BL9 currently expects Bootstrap >= 5.3.5 - Bootstrap 4 reached EOL Jan 2023. - Retain existing bootstrap_version variables for potential future use in BL9
1 parent 32ea6bb commit 5403e33

File tree

3 files changed

+3
-4
lines changed

3 files changed

+3
-4
lines changed

app/javascript/blacklight-frontend/checkbox_submit.js

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -10,7 +10,7 @@
1010
attribute (HTML5-style doc-*) that contains the id/primary key
1111
of the object in question -- used by plugin for a unique value for
1212
DOM id's.
13-
Uses HTML for a checkbox compatible with Bootstrap 4.
13+
Uses HTML for a checkbox compatible with Bootstrap.
1414
new CheckboxSubmit(document.querySelector('form.something')).render()
1515
*/
1616
export default class CheckboxSubmit {
@@ -36,7 +36,7 @@ export default class CheckboxSubmit {
3636
}).then((json) => {
3737
this.labelTarget.removeAttribute('disabled')
3838
this.checkboxTarget.removeAttribute('disabled')
39-
// For accessibility return keyboard focus
39+
// For accessibility return keyboard focus
4040
// back to the checkbox after form submission
4141
this.checkboxTarget.focus()
4242
this.updateStateFor(!this.checked)

lib/blacklight/configuration.rb

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -47,7 +47,6 @@ def initialized_default_configuration?
4747
property :header_component, default: Blacklight::HeaderComponent
4848
property :full_width_layout, default: false
4949

50-
# bootstrap_version may be set to 4 or 5
5150
bootstrap_version = ENV['BOOTSTRAP_VERSION'].presence || "5"
5251
property :bootstrap_version, default: /(\d)(?:\.\d){0,2}/.match(bootstrap_version)[1].to_i
5352

lib/generators/blacklight/templates/catalog_controller.rb

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -12,7 +12,7 @@ class <%= controller_name.classify %>Controller < ApplicationController
1212
# rescue_from Blacklight::Exceptions::InvalidRequest, with: :my_handling_method
1313
1414
configure_blacklight do |config|
15-
## Specify the style of markup to be generated (may be 4 or 5)
15+
## Specify the style of markup to be generated
1616
# config.bootstrap_version = 5
1717
#
1818
## Class for sending and receiving requests from a search index

0 commit comments

Comments
 (0)