Skip to content

Commit 87fe889

Browse files
jcoynecbeer
authored andcommitted
Remove role=treeitem
This was causing an accessability violation, because treeitems must be a child of a tree. https://developer.mozilla.org/en-US/docs/Web/Accessibility/ARIA/Roles/tree_role
1 parent 6bb33bc commit 87fe889

File tree

2 files changed

+2
-2
lines changed

2 files changed

+2
-2
lines changed

app/assets/stylesheets/blacklight/_facets.scss

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -126,7 +126,7 @@
126126
align-items: flex-start;
127127
padding: 3px 0;
128128

129-
&[role="treeitem"] {
129+
&.treeitem {
130130
display: block;
131131
}
132132

app/components/blacklight/facet_item_pivot_component.rb

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -32,7 +32,7 @@ def call
3232

3333
id = "h-#{self.class.mint_id}" if @collapsing && has_items?
3434

35-
content_tag @wrapping_element, role: 'treeitem', class: 'treeitem' do
35+
content_tag @wrapping_element, class: 'treeitem' do
3636
concat(content_tag('span', class: "d-flex flex-row align-items-center") do
3737
concat facet_toggle_button(id) if has_items? && @collapsing
3838
concat content_tag('span', render(facet), class: "facet-values d-flex flex-row flex-grow-1 #{'facet-leaf-node' if has_items? && @collapsing}", id: id && "#{id}_label")

0 commit comments

Comments
 (0)