-
Notifications
You must be signed in to change notification settings - Fork 256
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
link_to_facet can create links with identical text that goes to different URLs #3427
Labels
Comments
thatbudakguy
added a commit
that referenced
this issue
Oct 31, 2024
This updates the LinkToFacet rendering step to add an additional visually hidden element when creating a link to a faceted search that indicates the facet that will be used in the search. This helps give additional context to screen reader users when link_to_facet is used, especially when the page may include links that go to searches for the same value in different fields. Fixes #3427
thatbudakguy
added a commit
that referenced
this issue
Oct 31, 2024
This updates the LinkToFacet rendering step to add an additional visually hidden element when creating a link to a faceted search that indicates the facet that will be used in the search. This helps give additional context to screen reader users when link_to_facet is used, especially when the page may include links that go to searches for the same value in different fields. Fixes #3427
thatbudakguy
added a commit
that referenced
this issue
Oct 31, 2024
This updates the LinkToFacet rendering step to add an additional visually hidden element when creating a link to a faceted search that indicates the facet that will be used in the search. This helps give additional context to screen reader users when link_to_facet is used, especially when the page may include links that go to searches for the same value in different fields. Fixes #3427
jcoyne
changed the title
link_to_facet can create identical links that go to different searches
link_to_facet can create links with identical text that goes to different URLs
Nov 1, 2024
thatbudakguy
added a commit
that referenced
this issue
Nov 1, 2024
This updates the LinkToFacet rendering step to add an additional visually hidden element when creating a link to a faceted search that indicates the facet that will be used in the search. This helps give additional context to screen reader users when link_to_facet is used, especially when the page may include links that go to searches for the same value in different fields. Fixes #3427
thatbudakguy
added a commit
that referenced
this issue
Nov 1, 2024
This updates the LinkToFacet rendering step to add an additional visually hidden element when creating a link to a faceted search that indicates the facet that will be used in the search. This helps give additional context to screen reader users when link_to_facet is used, especially when the page may include links that go to searches for the same value in different fields. Fixes #3427
thatbudakguy
added a commit
that referenced
this issue
Nov 1, 2024
This updates the LinkToFacet rendering step to add an additional visually hidden element when creating a link to a faceted search that indicates the facet that will be used in the search. This helps give additional context to screen reader users when link_to_facet is used, especially when the page may include links that go to searches for the same value in different fields. Fixes #3427
thatbudakguy
added a commit
that referenced
this issue
Nov 1, 2024
This updates the LinkToFacet rendering step to add an additional visually hidden element when creating a link to a faceted search that indicates the facet that will be used in the search. This helps give additional context to screen reader users when link_to_facet is used, especially when the page may include links that go to searches for the same value in different fields. Fixes #3427
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
This issue only occurs when rendering a document that has two different fields with the same value. An example is this record in a Geoblacklight instance, which has the same organization as its creator and publisher.
The output of the
LinkToFacet
rendering step uses the field value as the link text, so this will create two different links on the page with the same text, but pointing to different searches since they are faceting on different fields.This is an accessibility issue for screen reader users, because the links can be presented out-of-context in a menu where they will not be able to be distinguished.
Sighted users can use the context of the nearby field name in a
<dt>
to distinguish the purpose of the two links, but non-sighted users may need additional context added to the accessible name for the link.The text was updated successfully, but these errors were encountered: