Extract a special purpose ConstraintPresenter #3690
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jcoyne
force-pushed
the
facet_field_label
branch
2 times, most recently
from
04f40b7 to
032d842
Compare
jcoyne
force-pushed
the
facet_field_label
branch
2 times, most recently
from
8361d31 to
2360a8c
Compare
This allows us to slim down the FacetItemPresenter as it isn't trying to do too many things
jcoyne
force-pushed
the
facet_field_label
branch
from
2360a8c to
aa711a3
Compare
jcoyne
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This allows us to slim down the FacetItemPresenter as it isn't trying to do too many things