add doc id for bookmark event #3693
Open
+4
−2
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jcoyne
reviewed
Jul 19, 2025
| @@ -6,7 +6,8 @@ | |||
| data: { | |||
| present: t('blacklight.search.bookmarks.present'), | |||
| absent: t('blacklight.search.bookmarks.absent'), | |||
| inprogress: t('blacklight.search.bookmarks.inprogress') | |||
| inprogress: t('blacklight.search.bookmarks.inprogress'), | |||
| doc_id: @document.id | |||
There was a problem hiding this comment.
Looks good, but let's go with document_id as that's what's more commonly used throughout the codebase.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The bookmark page currently doesn't up and remove bookmarks if they are deselected on the page. I think this would be a good update to blacklight and it is something Stanford wants now. I plan to bring this up during a call but for now this is the building block of making that functionality work.