Conversation
Contributor
Author
|
For example, see mesa/mesa-examples#151. |
|
Performance benchmarks:
|
rht
commented
Aug 10, 2024
| if group is self.model: | ||
| return reporter(group) | ||
| if isinstance(reporter, str): | ||
| if hasattr(group, "get"): |
Contributor
Author
There was a problem hiding this comment.
This should be replaced with isinstance(group, AgentSet) or isinstance of Group.
Member
|
Thanks for this effort! It doesn’t look too bad, could you give some example usages of more complicated usage scenarios? |
Contributor
Author
|
Which example do you want me to port? Is wolf-sheep (agents by type) sufficient? |
Member
|
I don't need a full model port, I would like some (more complex) API usage examples. Something in the form of: |
Contributor
Author
|
@EwoutH this should be a sufficient illustration: mesa/mesa-examples#158. It has agents by type. |
Member
|
This PR is stale, and we are at long last picking this up again. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Given that the fall semester is starting soon, there is not enough time to build a comprehensive new data collection API. So this is what I have cooked this afternoon.
It addresses #1944 (comment):
to_dfin this PR, and this feature is actually used in visualizationand #1944 (comment):
to_dfTODO: