Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add --pull always to the Docker options in the component's Makefile.vars.mk #35

Open
simu opened this issue Jan 3, 2023 · 0 comments
Open

Add --pull always to the Docker options in the component's Makefile.vars.mk #35

simu opened this issue Jan 3, 2023 · 0 comments
Labels
enhancement New feature or request

Comments

@simu
Copy link
Member

simu commented Jan 3, 2023 •
edited
Loading

Context

Recent versions of Docker Engine (20.10) and Podman (at least v2 and newer) support flag --pull always to specify that images should always be pulled. We should use this, as long as we're using :latest image tags for the container images we use in the component's Makefile.vars.mk`:

commodore-component-template/{{ cookiecutter.slug }}/Makefile.vars.mk

Line 26 in ef92fec

DOCKER_ARGS ?= run --rm -u "$$(id -u):$$(id -g)" --userns=$(DOCKER_USERNS) -w /$(COMPONENT_NAME) -e HOME="/$(COMPONENT_NAME)"

Alternatives

  • Switch to fixed image tags, and deal with renovate PRs on the template and the cascading PRs to update all components.
@simu simu added the enhancement New feature or request label Jan 3, 2023
@simu simu mentioned this issue Jan 20, 2023
Merged
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@simu