minor enhancement: return multi error when closeAll() (#663)

YaoZengzeng · krasi-georgiev · commit bff3ef3db4bd · 2019-07-19T12:16:34.000+03:00
Signed-off-by: YaoZengzeng &lt;yaozengzeng@zju.edu.cn&gt;
diff --git a/chunks/chunks.go b/chunks/chunks.go
@@ -502,11 +502,11 @@ func sequenceFiles(dir string) ([]string, error) {
 	return res, nil
 }
 
-func closeAll(cs []io.Closer) (err error) {
+func closeAll(cs []io.Closer) error {
+	var merr tsdb_errors.MultiError
+
 	for _, c := range cs {
-		if e := c.Close(); e != nil {
-			err = e
-		}
+		merr.Add(c.Close())
 	}
-	return err
+	return merr.Err()
 }

Original file line number	Diff line number	Diff line change
`@@ -502,11 +502,11 @@ func sequenceFiles(dir string) ([]string, error) {`
`502`	`502`	`return res, nil`
`503`	`503`	`}`
`504`	`504`
`505`		`-func closeAll(cs []io.Closer) (err error) {`
	`505`	`+func closeAll(cs []io.Closer) error {`
	`506`	`+ var merr tsdb_errors.MultiError`
	`507`	`+`
`506`	`508`	`for _, c := range cs {`
`507`		`- if e := c.Close(); e != nil {`
`508`		`- err = e`
`509`		`- }`
	`509`	`+ merr.Add(c.Close())`
`510`	`510`	`}`
`511`		`- return err`
	`511`	`+ return merr.Err()`
`512`	`512`	`}`