Fix race in writeHash

Signed-off-by: Ganesh Vernekar <[email protected]>

Author: Ganesh Vernekar

chunks/chunks.go

@@ -24,6 +24,7 @@ import (
 	"os"
 	"path/filepath"
 	"strconv"
+	"sync"
 
 	"github.com/pkg/errors"
 	"github.com/prometheus/tsdb/chunkenc"
@@ -55,14 +56,20 @@ type Meta struct {
 }
 
 // metaWriteHashBuf is the byte slice buffer used to write the hash.
-var metaWriteHashBuf = make([]byte, 1)
+var metaWriteHashBufPool = &sync.Pool{
+	New: func() interface{} {
+		return make([]byte, 1)
+	},
+}
 
 // writeHash writes the chunk encoding and raw data into the provided hash.
 func (cm *Meta) writeHash(h hash.Hash) error {
-	metaWriteHashBuf[0] = byte(cm.Chunk.Encoding())
-	if _, err := h.Write(metaWriteHashBuf); err != nil {
+	buf := metaWriteHashBufPool.Get().([]byte)
+	buf[0] = byte(cm.Chunk.Encoding())
+	if _, err := h.Write(buf); err != nil {
 		return err
 	}
+	metaWriteHashBufPool.Put(buf)
 	if _, err := h.Write(cm.Chunk.Bytes()); err != nil {
 		return err
 	}