Skip to content

Commit 2d748f0

Browse files
committed
Change label_replace and label_join test cases to fail when either legacy or UTF-8 name validation is enabled
Signed-off-by: Charles Korn <[email protected]>
1 parent cc002f3 commit 2d748f0

File tree

1 file changed

+2
-2
lines changed

1 file changed

+2
-2
lines changed

promql/promql-test-queries.yml

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -199,15 +199,15 @@ test_cases:
199199
- query: 'label_replace(demo_num_cpus, "job", "value-$1", "src", "(.*")'
200200
should_fail: true
201201
# label_replace fails when the destination label name is not a valid Prometheus label name.
202-
- query: 'label_replace(demo_num_cpus, "~invalid", "", "src", "(.*)")'
202+
- query: 'label_replace(demo_num_cpus, "\xff", "", "src", "(.*)")'
203203
should_fail: true
204204
# label_replace fails when there would be duplicated identical output label sets.
205205
- query: 'label_replace(demo_num_cpus, "instance", "", "", "")'
206206
should_fail: true
207207
- query: 'label_join(demo_num_cpus, "new_label", "-", "instance", "job")'
208208
- query: 'label_join(demo_num_cpus, "job", "-", "instance", "job")'
209209
- query: 'label_join(demo_num_cpus, "job", "-", "instance")'
210-
- query: 'label_join(demo_num_cpus, "~invalid", "-", "instance")'
210+
- query: 'label_join(demo_num_cpus, "\xff", "-", "instance")'
211211
should_fail: true
212212
- query: '{{.dateFunc}}()'
213213
variant_args: ['dateFunc']

0 commit comments

Comments
 (0)