pushgateway service stop has error log

[jiangpengjul]

[roidelapluie]

Can we get the full log line ? The actual error is missing.

Also, we do not provide systemd service file. Can we get the content of your pushgateway.service file?

Thanks!

[jiangpengjul]

[beorn7]

I guess the log line @jiangpengjul is referring to is level=error ts=2021-09-30T11:16:55.724Z caller=main.go:199 msg="HTTP server stopped" err="accept tcp [::]:9091: use of closed network connection" (or similar). Pushgateway indeed emits an error-level log line even on a graceful shutdown. That has to do with the way we handle shutting down the HTTP server. Nothing is really wrong with it, but I guess it could be done in a more elegant way. I would accept a PR. (o:

Relevant code:

• pushgateway/main.go

  Line 257 in 079d8d8

  l.Close()

• pushgateway/main.go

  Line 199 in 079d8d8

  level.Error(logger).Log("msg", "HTTP server stopped", "err", err)

[beorn7]

Note that the Pushgateway still has an exit code of zero upon graceful shutdown. Systemd should be fine with it (and appears to be fine). It's mostly a distraction for users that they see an error where nothing erroneous has happened.

[beorn7]

Note that #428 has fixed the behavior.