Skip to content

Commit 73e134e

Browse files
author
Baxter Eaves
committed
Make pylace default transitions hit everything
I went in to all a slice row kernel in sams, but found that `sams` didn't update state_alpha and `fast` didn't update anything but the row and column reassignment. Fixed.
1 parent 66e5a67 commit 73e134e

File tree

2 files changed

+11
-5
lines changed

2 files changed

+11
-5
lines changed

CHANGELOG.md

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -12,6 +12,8 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0
1212

1313
### Fixed
1414
- Initializing an engine with a codebook that has a different number of rows than the data will result in an error instead of printing a bunch on nonsense.
15+
- Pylace default transition sets didn't hit all required transitions
16+
- Typo in pylace internal `Dimension` class
1517

1618
## [python-0.6.0] - 2024-01-23
1719

pylace/lace/utils.py

Lines changed: 9 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -17,7 +17,7 @@
1717

1818
class Dimension:
1919
Rows = 0
20-
Colums = 1
20+
Columns = 1
2121

2222

2323
FN_IS_SYMMETRIC = {
@@ -28,8 +28,8 @@ class Dimension:
2828

2929

3030
FN_DIMENSION = {
31-
"mi": Dimension.Colums,
32-
"depprob": Dimension.Colums,
31+
"mi": Dimension.Columns,
32+
"depprob": Dimension.Columns,
3333
"rowsim": Dimension.Rows,
3434
}
3535

@@ -132,10 +132,10 @@ def infer_column_metadata(
132132
StateTransition.view_alphas(),
133133
StateTransition.row_assignment(RowKernel.sams()),
134134
StateTransition.view_alphas(),
135+
StateTransition.row_assignment(RowKernel.slice()),
135136
StateTransition.component_parameters(),
136137
StateTransition.column_assignment(ColumnKernel.gibbs()),
137-
StateTransition.column_assignment(ColumnKernel.slice()),
138-
StateTransition.view_alphas(),
138+
StateTransition.state_alpha(),
139139
StateTransition.feature_priors(),
140140
],
141141
"flat": [
@@ -151,8 +151,12 @@ def infer_column_metadata(
151151
StateTransition.feature_priors(),
152152
],
153153
"fast": [
154+
StateTransition.view_alphas(),
154155
StateTransition.row_assignment(RowKernel.slice()),
156+
StateTransition.component_parameters(),
157+
StateTransition.feature_priors(),
155158
StateTransition.column_assignment(ColumnKernel.slice()),
159+
StateTransition.state_alpha(),
156160
],
157161
}
158162

0 commit comments

Comments
 (0)