Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Protocol Buffers Edition 2023 Language Specification: Mismatched quotes in edition section #192

Open
jeeger opened this issue Oct 29, 2024 · 1 comment

Comments

@jeeger
Copy link

jeeger commented Oct 29, 2024

I think I found an error in the language specification grammar, where the quotes for the edition statement are mismatched.
From reading the specification, it seems like the edition should be specified as

edition = '2024"

which looks incorrect. The example use double quotes, and I guess the intention was to allow both double or single quotes.

edition = "edition" "=" (("'"decimalLit "'") | ('"' decimalLit '"')) ";"

(for clarification, that's double-single-double quotes and single-double-single quotes).

@Logofile
Copy link
Member

Logofile commented Nov 1, 2024

You're right. I've submitted a change for review. Thanks for catching this!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants