Subsurface rivers (tunnel=culvert) are very prominently rendered including labels

[EconomicTouristsArmLate]

this is the issue i alluded to in #240 (comment).

(the other issue -- labels on small basins/ponds rendered when text was much larger than their geometry -- seems to be already resolved in the latest maps).

Description

Labels & waterways of subsurface rivers are rendered quite prominently.
I'd like them to be

• rendered in a different manner than surface-waterways, or not at all.
• rendered without labels

The relevant tagging in OSM is waterway=stream layer=-1 tunnel=culvert, example way 1 example way 2

(see also https://wiki.openstreetmap.org/wiki/Tag:tunnel=culvert)

Location
This is very prominent in the city of Aachen (Germany), which is home to several small springs. The related (small) creeks (eg Pau were mostly moved below surface in the city center and are not part of the visible city (wrt landmarks, navigation). The names of the tributaries to the resulting bigger creek Wurm are not commonly known.

• Creek "Pau" below surface in the city center
  

• A good testcase: upstream, north of the basin, the creek runs subsurface, and shouldn't be rendered.
  

Screenshots
Other map impementations:

• (osm foundation default mapnik style) renders subsurface rivers with a dashed, less prominent style, and doesnt render their labels:
  

• wikimedia maps doesnt render the labels, but still renders subsurface rivers
  

[EconomicTouristsArmLate]

while we are at it, these waterways tagged as ways (instead of areas) are super small, 1px on high res displays. i would consider making them a bit more visible

[wipfli]

Thanks for reporting. Tilezen included the tunnel tag for waterways: https://github.com/tilezen/vector-datasource/blob/89eeec6e98c6f5ae25d72970953ba93bb8b635a1/yaml/water.yaml#L14

I think I might have removed it during the matcher refactor. Let me check...

[wipfli]

Actually tunnel was already removed from line features before the matcher refactor, see

basemaps/tiles/src/main/java/com/protomaps/basemap/layers/Water.java

Lines 211 to 212 in 2eb7c51

	//.setAttrWithMinzoom("bridge", sf.getString("bridge"), 12)
	//.setAttrWithMinzoom("tunnel", sf.getString("tunnel"), 12)

Feel free to open a pull request to fix this @EconomicTouristsArmLate

[wipfli]

I'm adding a render test for this issue in #485. The test has the current behavior, i.e., text labels on the river Pau. When we fix this issue here, the test should break and we will need to update it.

[EconomicTouristsArmLate]

Thanks @wipfli ! you were quicker than I could find time..

I would also like to see a viz change of the lines of the waterway tunnels.
I'll try to tackle that, as #486 only removes labels.