Skip to content

Subsurface rivers (tunnel=culvert) are very prominently rendered including labels #481

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
EconomicTouristsArmLate opened this issue May 19, 2025 · 5 comments · May be fixed by #486
Open

Comments

@EconomicTouristsArmLate
Copy link

EconomicTouristsArmLate commented May 19, 2025

this is the issue i alluded to in #240 (comment).

(the other issue -- labels on small basins/ponds rendered when text was much larger than their geometry -- seems to be already resolved in the latest maps).

Description

Labels & waterways of subsurface rivers are rendered quite prominently.
I'd like them to be

  • rendered in a different manner than surface-waterways, or not at all.
  • rendered without labels

The relevant tagging in OSM is waterway=stream layer=-1 tunnel=culvert, example way 1 example way 2

(see also https://wiki.openstreetmap.org/wiki/Tag:tunnel=culvert)

Location
This is very prominent in the city of Aachen (Germany), which is home to several small springs. The related (small) creeks (eg Pau were mostly moved below surface in the city center and are not part of the visible city (wrt landmarks, navigation). The names of the tributaries to the resulting bigger creek Wurm are not commonly known.

Screenshots
Other map impementations:

  • (osm foundation default mapnik style) renders subsurface rivers with a dashed, less prominent style, and doesnt render their labels:
    Image

  • wikimedia maps doesnt render the labels, but still renders subsurface rivers
    Image

@EconomicTouristsArmLate
Copy link
Author

while we are at it, these waterways tagged as ways (instead of areas) are super small, 1px on high res displays. i would consider making them a bit more visible

@EconomicTouristsArmLate EconomicTouristsArmLate changed the title Subsurface rivers (tunnel=culvert) shouldn't be rendered on the map Subsurface rivers (tunnel=culvert) are very prominently rendered including labels May 19, 2025
@wipfli
Copy link
Collaborator

wipfli commented May 23, 2025

Thanks for reporting. Tilezen included the tunnel tag for waterways: https://github.com/tilezen/vector-datasource/blob/89eeec6e98c6f5ae25d72970953ba93bb8b635a1/yaml/water.yaml#L14

I think I might have removed it during the matcher refactor. Let me check...

@wipfli
Copy link
Collaborator

wipfli commented May 23, 2025

Actually tunnel was already removed from line features before the matcher refactor, see

//.setAttrWithMinzoom("bridge", sf.getString("bridge"), 12)
//.setAttrWithMinzoom("tunnel", sf.getString("tunnel"), 12)

Feel free to open a pull request to fix this @EconomicTouristsArmLate

@wipfli
Copy link
Collaborator

wipfli commented May 26, 2025

I'm adding a render test for this issue in #485. The test has the current behavior, i.e., text labels on the river Pau. When we fix this issue here, the test should break and we will need to update it.

@wipfli wipfli linked a pull request May 27, 2025 that will close this issue
@EconomicTouristsArmLate
Copy link
Author

EconomicTouristsArmLate commented May 30, 2025

Thanks @wipfli ! you were quicker than I could find time..

I would also like to see a viz change of the lines of the waterway tunnels.
I'll try to tackle that, as #486 only removes labels.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants