-
-
Notifications
You must be signed in to change notification settings - Fork 69
Subsurface rivers (tunnel=culvert) are very prominently rendered including labels #481
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Comments
while we are at it, these waterways tagged as ways (instead of areas) are super small, 1px on high res displays. i would consider making them a bit more visible |
Thanks for reporting. Tilezen included the I think I might have removed it during the matcher refactor. Let me check... |
Actually basemaps/tiles/src/main/java/com/protomaps/basemap/layers/Water.java Lines 211 to 212 in 2eb7c51
Feel free to open a pull request to fix this @EconomicTouristsArmLate |
I'm adding a render test for this issue in #485. The test has the current behavior, i.e., text labels on the river Pau. When we fix this issue here, the test should break and we will need to update it. |
Uh oh!
There was an error while loading. Please reload this page.
this is the issue i alluded to in #240 (comment).
(the other issue -- labels on small basins/ponds rendered when text was much larger than their geometry -- seems to be already resolved in the latest maps).
Description
Labels & waterways of subsurface rivers are rendered quite prominently.
I'd like them to be
The relevant tagging in OSM is
waterway=stream layer=-1 tunnel=culvert
, example way 1 example way 2(see also https://wiki.openstreetmap.org/wiki/Tag:tunnel=culvert)
Location
This is very prominent in the city of Aachen (Germany), which is home to several small springs. The related (small) creeks (eg Pau were mostly moved below surface in the city center and are not part of the visible city (wrt landmarks, navigation). The names of the tributaries to the resulting bigger creek Wurm are not commonly known.
Creek "Pau" below surface in the city center

A good testcase: upstream, north of the basin, the creek runs subsurface, and shouldn't be rendered.

Screenshots
Other map impementations:
(osm foundation default mapnik style) renders subsurface rivers with a dashed, less prominent style, and doesnt render their labels:

wikimedia maps doesnt render the labels, but still renders subsurface rivers

The text was updated successfully, but these errors were encountered: