Skip to content

[BUG] Error when self.legacy is set to True #156

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
blakejameson opened this issue Feb 9, 2025 · 1 comment
Open

[BUG] Error when self.legacy is set to True #156

blakejameson opened this issue Feb 9, 2025 · 1 comment
Labels
bug Something isn't working Understood Tag for bugs that have been solved!

Comments

@blakejameson
Copy link
Contributor

blakejameson commented Feb 9, 2025

Summary

When legacy is set to 'true' in the config.json, this can cause an error. The Satellite has a property called self.legacy, whose boolean value is dictated by the config.json.

During the Satellite initialization process, a field called self.enable_rf is set to be a digitialIO object if self.legacy is True. However, as shown in screenshot below, a board.RF_ENAB pin in the firmware is attempted to be used.
Image

When the board.RF_ENAB pin is not found, this results in an error that looks like the following:
Image

@Mikefly123 filled me in on the error in an earlier PR: #151 (comment)

To quote Michael,
"I was actually just thinking, once the config.json write updates are made, this could be a way for us to autodetect what version of firmware is running and set the legacy variable to True automagically if this issue is detected."

Steps to reproduce

change legacy to equal 'true' in the config.json and run the code
Image

Environment

@blakejameson blakejameson added the bug Something isn't working label Feb 9, 2025
@blakejameson blakejameson changed the title [BUG] <Error when self.legacy is set to True> [BUG] Error when self.legacy is set to True Feb 9, 2025
@Mikefly123 Mikefly123 added the Understood Tag for bugs that have been solved! label Feb 9, 2025
@Mikefly123
Copy link
Member

Mikefly123 commented Feb 9, 2025

Explanation of the Bug Cause

Just to add a little bit more context to this, if you are using a legacy configuration of the PROVES Kit (i.e. a V4 Flight Controller Board with a V2 Battery Board like the InspireFly Team) the pinout of the Flight Controller board needs to be completely different than what it is if you are using the latest configuration of the PROVES Kit (V4 Flight Controller Board with a V3 Battery Board).

In the latest configuration the flight controller board does not have access to the voltage regulator that supplies power to the radios, because of that there is no pin on the board that is configured as board.RF_ENAB. In legacy configurations and in the upcoming V5 Flight Controller Board we are planning to return this functionality so the flight controller board is able to directly turn on or off the power to the radio module.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working Understood Tag for bugs that have been solved!
Projects
None yet
Development

No branches or pull requests

2 participants