Skip to content

[FEATURE] Implement Type Checking into CI #234

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
2 tasks
blakejameson opened this issue Apr 14, 2025 · 2 comments
Open
2 tasks

[FEATURE] Implement Type Checking into CI #234

blakejameson opened this issue Apr 14, 2025 · 2 comments
Labels
enhancement New feature or request

Comments

@blakejameson
Copy link
Contributor

Story

  • As a developer
  • I want to type check my code
  • So that I can ensure the code is more reliable

Acceptance Criteria

  • Introduce a type checker that is checking several files
  • Type checker runs automatically in CI

Technical Details

Currently, there is no type checking be done. Type checking could allow us to ensure we are using variables and functions in a correct manner

@blakejameson blakejameson added the enhancement New feature or request label Apr 14, 2025
@blakejameson blakejameson changed the title [FEATURE] <title> [FEATURE] Implement Type Checking into CI Apr 14, 2025
@nateinaction
Copy link
Member

I have started a branch with some new tooling using pyright: https://github.com/proveskit/pysquared/tree/try-out-pyright

When on that branch you can run make typecheck to try it out. There are ~350 identified errors so could be a good weekend project.

@Mikefly123
Copy link
Member

Hey @blakejameson I think this was achieved with #239? If so this is another successful ticket we can close!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

3 participants