Skip to content

[FEATURE] Send Logger to Config Constructor #238

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
3 tasks
Alandlt15 opened this issue Apr 18, 2025 · 0 comments
Open
3 tasks

[FEATURE] Send Logger to Config Constructor #238

Alandlt15 opened this issue Apr 18, 2025 · 0 comments
Assignees
Labels
enhancement New feature or request

Comments

@Alandlt15
Copy link
Contributor

Alandlt15 commented Apr 18, 2025

Story

  • As a software developer
  • I want to be able to log info and error messages inside of the config class at initialization
  • So that parsing and error messages are logged appropriately

Acceptance Criteria

  • Send the logger object to the config constructor
  • Wrap this code in a try catch:
with open(config_path, "r") as f:
    json_data = json.loads(f.read())
  • Watch info or error messages get logged!

Technical Details

In the current implementation of the code, the logger class is initialized before the config class. I'm not sure if there is a reason why the logger is not sent to the config's constructor for logging purposes?

@Alandlt15 Alandlt15 added the enhancement New feature or request label Apr 18, 2025
@Alandlt15 Alandlt15 changed the title [FEATURE] <title> [FEATURE] Send Logger to Config Constructor Apr 18, 2025
@Alandlt15 Alandlt15 self-assigned this Apr 18, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant