Skip to content

Commit 1b6f2d1

Browse files
authored
Merge pull request #22 from weirdan/drop-legacy-package-versions
Removed LegacyVersions (muglug/package-versions-56) support
2 parents 4883024 + 01d9f30 commit 1b6f2d1

File tree

2 files changed

+5
-7
lines changed

2 files changed

+5
-7
lines changed

.gitignore

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1,2 +1,3 @@
11
composer.lock
22
vendor
3+
tests/_output/*

src/Module.php

Lines changed: 4 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -13,7 +13,6 @@
1313
use Composer\InstalledVersions;
1414
use Composer\Semver\Semver;
1515
use Composer\Semver\VersionParser;
16-
use Muglug\PackageVersions\Versions as LegacyVersions;
1716
use PackageVersions\Versions;
1817
use PHPUnit\Framework\Assert;
1918
use Behat\Gherkin\Node\TableNode;
@@ -474,19 +473,17 @@ function (array $error): array {
474473

475474
private function getShortVersion(string $package): string
476475
{
477-
/** @psalm-suppress DeprecatedClass Support of legacy code */
476+
/** @psalm-suppress DeprecatedClass Versions is marked deprecated for no good reason */
478477
if (class_exists(InstalledVersions::class)) {
479478
/** @psalm-suppress UndefinedClass Composer\InstalledVersions is undefined when using Composer 1.x */
480479
return (string) InstalledVersions::getPrettyVersion($package);
481480
} elseif (class_exists(Versions::class)) {
482-
/** @psalm-suppress UndefinedClass psalm 3.0 ignores class_exists check */
481+
/** @psalm-suppress ArgumentTypeCoercion Versions::getVersion() has too narrow a signature */
483482
$version = (string) Versions::getVersion($package);
484-
} elseif (class_exists(LegacyVersions::class)) {
485-
$version = (string) LegacyVersions::getVersion($package);
486483
} else {
487484
throw new RuntimeException(
488-
'Neither muglug/package-versions-56 nor ocramius/package-version is available,'
489-
. ' cannot determine versions'
485+
'Cannot determine versions. Neither of composer:2+,'
486+
. ' ocramius/package-version or composer/package-versions-deprecated are installed.'
490487
);
491488
}
492489

0 commit comments

Comments
 (0)