Merge pull request #13 from aspriya/tests-for-error-handling

Tests for error handling

Author: jywarren

dist/inlineMarkdownEditor.js

@@ -10386,8 +10386,6 @@ module.exports = function processSection(markdown, o) {
       .done(function onComplete(response) {
         // we should need fewer things here:
         o.onComplete(response, after, html, _el, uniqueId, __form, o);
-      }).error(function onFail(response) {
-        o.onFail(response, uniqueId);
       }).fail(function onFail(response) {
         o.onFail(response, uniqueId);
       }); // these don't work?

spec/javascripts/error_handling_spec.js

@@ -0,0 +1,34 @@
+describe('error handling by onFail', function () {
+  
+  var editor, html = "A simple text line";
+
+  beforeEach(function() {
+    fixture = loadFixtures('index.html');
+    $('.markdown').html(html);
+    editor = inlineMarkdownEditor({
+      replaceUrl: '/wiki/replace/',
+      selector: '.markdown'
+    });
+  });
+
+  it("should call onFail", function(){
+    jasmine.Ajax.install();
+
+    spyOn(editor.options, "onComplete");
+    spyOn(editor.options, "onFail");
+
+    spyOn($, "post").and.callFake(function(options) {
+      //here options is /wiki/replace/  
+      var d = $.Deferred();
+      d.reject("this is the response");     
+      return d.promise();
+    });
+  
+    $('.inline-edit-btn').click(); // generate editor by clicking the pencil icon
+    $('.inline-edit-form button.submit').click(); //click the save button in that form to send the post request
+
+    expect(editor.options.onComplete).not.toHaveBeenCalled();
+    expect(editor.options.onFail).toHaveBeenCalled();
+  });
+  
+})

src/processSection.js

@@ -62,8 +62,6 @@ module.exports = function processSection(markdown, o) {
       .done(function onComplete(response) {
         // we should need fewer things here:
         o.onComplete(response, after, html, _el, uniqueId, __form, o);
-      }).error(function onFail(response) {
-        o.onFail(response, uniqueId);
       }).fail(function onFail(response) {
         o.onFail(response, uniqueId);
       }); // these don't work?