-
Notifications
You must be signed in to change notification settings - Fork 399
Open
Labels
priority: mediumThis PR should be reviewed after all high priority PRs.This PR should be reviewed after all high priority PRs.status: waitingThis issue waits for feedback from author.This issue waits for feedback from author.type: questionThis issue is a question.This issue is a question.
Description
When editing a message I’ve noticed an issue: going from the message text A
to B
and then back to A
causes a 409 conflict error. However, if I edit from A
to B
, then to C
, and finally back to A, there’s no conflict. This behavior is confusing—why does the system only check the previous action?
Function that we're having issues with:
https://github.com/pubnub/js-chat/blob/master/lib/src/entities/message.ts#L202
What would be the best way to work around this behavior when editing a message?
Idea 1:
We could delete all actions following the conflict, but the time token would not update.
Idea 2:
Delete all the edit actions, but then changes in the UI flash from A
to EMPTY
to B
to EMPTY
to A
stephenlb
Metadata
Metadata
Assignees
Labels
priority: mediumThis PR should be reviewed after all high priority PRs.This PR should be reviewed after all high priority PRs.status: waitingThis issue waits for feedback from author.This issue waits for feedback from author.type: questionThis issue is a question.This issue is a question.