Skip to content
This repository has been archived by the owner on Sep 2, 2018. It is now read-only.

Zombie Process' #22

Closed
DaneEveritt opened this issue May 18, 2015 · 12 comments
Closed

Zombie Process' #22

DaneEveritt opened this issue May 18, 2015 · 12 comments
Assignees

Comments

@DaneEveritt
Copy link
Contributor

It appears that there is a bug with pty.js (see here and here) which prevents stopped processes from actually closing out correctly, so they become zombies to the scales.js process.

Not sure how we will go about fixing this, but at this point it doesn't look like there is too much we can do unfortunately. It was suggested to use waitpid(), however that doesn't seem to be compatible with NodeJS 0.12, unless that was just a bug on my system.

To reproduce this, simply start a server and then stop it. You can do this over and over, and then run ps aux | grep <process> (i.e. java) and you will see a long list of zombie processes form over time.

@DDynamic
Copy link

@LordRalex do you think you'll be able to fix this? Or will we have to wait for @DaneEveritt to return? This is a pretty big issue.

@LordRalex
Copy link
Member

@BlameDylan I have 0 knowledge of nodejs or Scales. I can BS a fix if I spend time on it, but at this point, that time is hard to get. I'd rather have someone help patch it and submit a PR, since that requires less time for me to allocate.

@DDynamic
Copy link

I'm currently learn NodeJS. Maybe I can do something.

@Mstrodl
Copy link

Mstrodl commented Jul 2, 2015

Is there any sort of work-around for this? Is it as simple as restarting Scales?

@aadeg
Copy link

aadeg commented Jul 24, 2015

It will be fixed soon?

@DDynamic
Copy link

@aadeg I think it has been fixed in the "zombies" branch.

@aadeg
Copy link

aadeg commented Jul 25, 2015

@BlameDylan The last commit was 1 month ago... I hope it will be fixed.

@Mstrodl
Copy link

Mstrodl commented Jul 25, 2015

@aadeg The commit message says

Attempt to fix zombie processes

@DaneEveritt
Copy link
Contributor Author

You can fix the Zombie Process issue by just restarting Scales for now. There is nothing we can do until it is fixed in an upstream dependency branch.

LordRalex added a commit that referenced this issue Aug 12, 2015
Possible fix to #22
@LordRalex
Copy link
Member

pty.js has made some updates and it appears those update may fix this issue. If this issue continues using the latest Scales release, please comment on this issue.

@DaneEveritt
Copy link
Contributor Author

Make sure to npm update after applying the change.

@LordRalex
Copy link
Member

With 0.1.4 released, and the fix in theory applied, I am closing this. Should pty.js fix it in the future on the 0.2.x builds, npm update will apply it.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

5 participants