Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Access and Language facets selected in the advanced search are displaying twice #3384

Closed
1 task
sandbergja opened this issue Jan 26, 2023 · 2 comments
Closed
1 task
Assignees
Labels
bug 🐛 The application does not work as expected because of a defect maintenance Ticket related to maintenance that needs to be done

Comments

@sandbergja
Copy link
Member

sandbergja commented Jan 26, 2023

Expected behavior

The advanced search screen allows you to choose "inclusive facets", meaning that they use a Boolean OR rather than Boolean AND. The search results page should display these facets, but not multiple times.

Actual behavior

The Access and Language facets are displaying the "Any of:" box twice! The format facets don't appear to be affected

access facet includes two boxes, both of which say Any of: In the library, Online

language facet includes two boxes, both of which say Any of: Acoli, Adangme

Steps to replicate

  1. Go to https://catalog.princeton.edu/advanced
  2. Select multiple values in the Access dropdown
  3. Select multiple values in the Language dropdown
  4. Press the search button
  5. Look at the facets on the side of the search results screen

Impact of this bug

Odd, cluttered, and potentially confusing UI

Acceptance criteria

  • Check this on the blacklight 8 branch. If Blacklight 8 fixes it, then close this ticket. Otherwise fix it for both main and the blacklight 8 branch.

Notes

I suspect this bug was introduced as part of the Blacklight deprecation work.

@christinach christinach added bug 🐛 The application does not work as expected because of a defect maintenance Ticket related to maintenance that needs to be done labels Feb 27, 2023
@sandbergja
Copy link
Member Author

sandbergja commented Mar 14, 2023

I wonder if this is the same as projectblacklight/blacklight_advanced_search#127 ?

@christinach
Copy link
Member

christinach commented Dec 17, 2024

This is not anymore a bug in production - blacklight 7.
Deployed Blacklight8-upgrade-v2 on catalog-staging and tested the advanced search facets. It does not exist in blacklight 8 as well.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug 🐛 The application does not work as expected because of a defect maintenance Ticket related to maintenance that needs to be done
Projects
None yet
Development

No branches or pull requests

2 participants