Skip to content

fix(timeline): 危険なキャストの除去 #1051

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
MikuroXina opened this issue May 4, 2025 · 0 comments
Open

fix(timeline): 危険なキャストの除去 #1051

MikuroXina opened this issue May 4, 2025 · 0 comments
Labels
T: refactoring
Milestone
Pulsate v0.1.0

Comments

@MikuroXina
Copy link
Contributor

timeline パッケージにおけるレポジトリのダミー実装 において, readonly な配列から通常の配列への危険なキャストが起こっています. 内部実装としてはスプレッド演算で複製されているので問題にはなりませんが, モデルの定義を変えるかレポジトリ側でも複製するかしておかないと, そのうちバグを作り込む可能性があります.
@laminne laminne added this to the Pulsate v0.1.0 milestone May 18, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
T: refactoring
Projects
None yet
Milestone
Pulsate v0.1.0
Development

No branches or pull requests
2 participants
@MikuroXina @laminne