Skip to content

chore: InMemoryRepositoryでデータの保存にSetではなくMapを使うように #824

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
laminne opened this issue Nov 13, 2024 · 0 comments
Open

chore: InMemoryRepositoryでデータの保存にSetではなくMapを使うように #824

laminne opened this issue Nov 13, 2024 · 0 comments
Labels
good first issue Recommended Issue for new contributors P: low T: refactoring

Comments

@laminne
Copy link
Member

laminne commented Nov 13, 2024

やること

理由:

同じ AccountID を持つ異なる Account 型のオブジェクトが混ざる可能性があるので, Set<Account> ではなく Map<AccountID, Account> を使ったほうがよいかと思います.

#823 (comment)

  • データの保存にSetではなくMapを使うようにする
  • 他にSetを使っているところがないかを調査する
@laminne laminne added the T: improvement Improvement of functions, etc. label Nov 13, 2024
@laminne laminne moved this from Todo to Backlog in Pulsate v0.1 Nov 29, 2024
@laminne laminne added good first issue Recommended Issue for new contributors T: refactoring P: low and removed T: improvement Improvement of functions, etc. labels Jan 28, 2025
@MikuroXina MikuroXina moved this from Backlog to Todo in Pulsate v0.1 Mar 17, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
good first issue Recommended Issue for new contributors P: low T: refactoring
Projects
Pulsate v0.1
Status: Todo
Milestone
No milestone
Development

No branches or pull requests
1 participant
@laminne